Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mf2py (waiting for next release) #828

Closed
sknebel opened this issue May 30, 2018 · 7 comments
Closed

Update mf2py (waiting for next release) #828

sknebel opened this issue May 30, 2018 · 7 comments

Comments

@sknebel
Copy link
Contributor

sknebel commented May 30, 2018

Exciting new features! E.g. improved implied name handling, which keeps cropping up. (e.g. http://twtr.io/1eNFR0C3voG )
@snarfed
Copy link
Owner

snarfed commented May 31, 2018

yes! this should fix or at least help with snarfed/granary#145 and snarfed/granary#142 too.

bridgy is pretty particular about mf2py's behavior, and some new changes are nontrivial, eg it adds img URLs to implied names in some (all?) cases, so this will take more work than just bumping the version. still, definitely worthwhile!
snarfed added a commit to snarfed/granary that referenced this issue May 31, 2018
@snarfed
upgrade mf2py to 1.1.0
43480cb 
for snarfed/bridgy#828, #145, #142, etc.
@snarfed
Copy link
Owner

snarfed commented Jun 1, 2018

the img URL thing did turn out to be a dealbreaker for mf2py 1.1.0. details in microformats/microformats2-parsing#35 .

the good news is, it sounds like everyone agrees that we should revert that part of the spec, so hopefully I'll be able to upgrade to the next mf2py release!
@snarfed snarfed changed the title Update mf2py Jun 5, 2018
@snarfed
Copy link
Owner

snarfed commented Jul 17, 2018

woo, thanks to @kartikprabhu for implementing the implied name change! microformats/mf2py@71997eb. can't wait for the next release!
snarfed added a commit to snarfed/granary that referenced this issue Jul 18, 2018
@snarfed
upgrade mf2py to 1.1.1
a989c3e 
fixes #142, fixes #145, fixes snarfed/bridgy#756, for snarfed/bridgy#828
snarfed added a commit that referenced this issue Jul 24, 2018
@snarfed
upgrade mf2py to 1.1.2 (unreleased)
9c2c504 
details in #828, snarfed/granary#142, snarfed/granary@a989c3e, etc.
snarfed added a commit that referenced this issue Jul 24, 2018
@snarfed
upgrade mf2py to 1.1.2 (unreleased)
b77cccb 
details in #828, snarfed/granary#142, snarfed/granary@a989c3e, etc.
snarfed added a commit that referenced this issue Jul 24, 2018
@snarfed
upgrade mf2py to 1.1.2 (unreleased)
b54bed4 
details in #828, snarfed/granary#142, snarfed/granary@a989c3e, etc.
@snarfed
Copy link
Owner

snarfed commented Jul 24, 2018

deployed this just now with https://github.com/snarfed/mf2py/tree/all , which has a number of pending mf2py bug fixes, eg microformats/mf2py#115 and microformats/mf2py#118. 🤞
@snarfed
Copy link
Owner

snarfed commented Jul 24, 2018

rolling back, it's currently crashing on microformats/mf2py#108 . e.g. https://brid.gy/log?start_time=1532441945&key=aglzfmJyaWQtZ3lyFgsSB1R3aXR0ZXIiCXNjaHVzc21hbgw
@snarfed
Copy link
Owner

snarfed commented Jul 25, 2018

added microformats/mf2py#114 and it's no longer crashing. mf2py at head (with a bunch more unmerged bug fixes) is now live on bridgy prod.
@snarfed
Copy link
Owner

snarfed commented Aug 8, 2018

closing, yay. thanks again @sknebel!
@snarfed snarfed closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@snarfed @sknebel