Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish: add post author id to Facebook comment permalink #265

Closed
kylewm opened this issue Aug 18, 2014 · 4 comments
Closed

publish: add post author id to Facebook comment permalink #265

kylewm opened this issue Aug 18, 2014 · 4 comments
Labels
publish

Comments

@kylewm
Copy link
Contributor

kylewm commented Aug 18, 2014

when publishing a comment to Facebook, Bridgy reports this URL (which is a 404)
/POST_ID/?comment_id=COMMENT_ID
Should be
/AUTHOR_ID/posts/POST_ID/?comment_id=COMMENT_ID

Looks like this is handled in a-u.Facebook.comment_url, and we just need to pass the post_author_id (parsed from base_url) here:

https://github.com/snarfed/activitystreams-unofficial/blob/master/facebook.py#L355
@kylewm kylewm added the publish label Aug 18, 2014
@kylewm
Copy link
Contributor Author

kylewm commented Aug 18, 2014

just tried replying to an event, looks like bridgy gives me the syndication URL
/EVENT_ID?comment_id=COMMENT_ID

which FB redirects to
/events/EVENT_ID?comment_id=COMMENT_ID
@snarfed
Copy link
Owner

snarfed commented Aug 19, 2014

thanks for filing! all of that makes sense. i'd happily merge a PR that fixes either or both!

btw, i don't think i'd ever tried or tested commenting on an event. kind of nice that it worked automatically! (even if we do still need to clean up the returned URL.)
@snarfed
Copy link
Owner

snarfed commented Aug 19, 2014

...actually, no need for the PR at this point, go ahead and push small/medium changes whenever! :shipit:
@snarfed snarfed added the now label Aug 20, 2014
snarfed referenced this issue in snarfed/granary Aug 30, 2014
@snarfed
change Source.base_object() to return an ActivityStreams object
93ebfd8 
useful for including author too, for #265
@snarfed
Copy link
Owner

snarfed commented Aug 30, 2014

i'm going to skip the /events/ URL prefix because FB redirects, and because i'm lazy. :P
@snarfed snarfed closed this as completed Aug 30, 2014
snarfed added a commit to snarfed/granary that referenced this issue Aug 30, 2014
@snarfed
facebook: after creating a comment, try to include the post author id…
30a60a2 
… in the returned URL

for snarfed/bridgy#265

R=@kylewm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish
2 participants
@snarfed @kylewm