Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't report webmention failures as task failures #1

Closed
snarfed opened this issue Jan 4, 2014 · 2 comments
Closed

don't report webmention failures as task failures #1

snarfed opened this issue Jan 4, 2014 · 2 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jan 4, 2014

...in the app engine dashboard. specifically, find an HTTP status code that will make the task queue retry but won't show up as an error request. not sure it exists, but would be nice.

@snarfed
Copy link
Owner Author

snarfed commented Jan 5, 2014

i'm not sure there's an easy way to do this, at least the way i currently use the task queue. the task queue needs a non-2XX status code to retry, and it looks like those are exactly the codes that are reported as errors on the dashboard.

possible fixes:

  • catch all exceptions and enqueue a new task manually instead of returning an error status code
  • switch to pull queues

both are nontrivial. :/

@snarfed
Copy link
Owner Author

snarfed commented Jan 5, 2014

i take it back! looks like the request summary chart only treats 4xx and 5xx as errors. i've switched to 306 in 5f45a5e, which still makes the tasks retry.

@snarfed snarfed closed this as completed Jan 5, 2014
snarfed added a commit that referenced this issue Dec 7, 2015
…de links

fixes #565

as a side effect, i moved link search out of poll and into the source classes. poll step #1 is now way more pleasant to read. you're welcome. ok mostly i'm welcome. :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant