Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS feed missing details #429

Closed
aciccarello opened this issue Feb 17, 2023 · 3 comments
Closed

RSS feed missing details #429

aciccarello opened this issue Feb 17, 2023 · 3 comments

Comments

@aciccarello
Copy link

It looks like the RSS feed is missing some details. I'll switch to the atom feed for now but seemed like a bug considering it is in one feed file but not the other.

RSS Feed item

feed reader screenshot with text but no image or author

Atom Feed item

feed reader screenshot showing image and author info
@snarfed
Copy link
Owner

snarfed commented Feb 17, 2023

Oof, yes, thanks for filing. Looks like a granary feature request, it's not currently rendering image enclosures, repost contexts, etc. And it's sorted the wrong direction, by date ascending instead of descending. Whee!
snarfed added a commit to snarfed/granary that referenced this issue Feb 17, 2023
@snarfed
rss.from_activities: fix item ordering to match input activities
5846e3d 
for snarfed/bridgy-fed#429
@snarfed
Copy link
Owner

snarfed commented Apr 18, 2023

Confirmed that RSS is now also including the "Shared a post by ..." header for reposts, eg on https://monocle.p3k.io/preview?url=https%3A%2F%2Ffed.brid.gy%2Fuser%2Fsnarfed.org%2Ffeed%3Fformat%3Drss
snarfed added a commit to snarfed/granary that referenced this issue Apr 18, 2023
@snarfed
add rss.from_activities() test for repost header
33e0a90 
snarfed/bridgy-fed#429
snarfed added a commit to snarfed/granary that referenced this issue Apr 18, 2023
@snarfed
as2.to_as1: propagate image attachments into image as well as `atta…
355ab27 
…chments`

for snarfed/bridgy-fed#429
@snarfed
Copy link
Owner

snarfed commented Apr 18, 2023

And images are now in too. Phew. Done, I think! Thanks again for reporting @aciccarello.
@snarfed snarfed closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@snarfed @aciccarello