Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post don't get linked on Sharkey while truncated #1155

Closed
AtiusAmy opened this issue Jun 26, 2024 · 3 comments
Closed

Post don't get linked on Sharkey while truncated #1155

AtiusAmy opened this issue Jun 26, 2024 · 3 comments

Comments

@AtiusAmy
Copy link

On Sharkey, posts seem to not get linked on Sharkey while truncated:

https://bsky.app/profile/atiusamy.social.atiusamy.com.ap.brid.gy/post/3kvst7puqgvc2

However, my boyfriend (on GoToSocial) have linked to the full version

https://bsky.app/profile/winsdominoes.fedi.winscloud.net.ap.brid.gy/post/3kvslnmqo7br2

@snarfed
Copy link
Owner

snarfed commented Jun 26, 2024

Interesting! Thanks for reporting. Looks like this is because, surprisingly, Sharkey AS2 objects don't have the url field, which is the human-readable URL to the post. For example, here's your Note object https://social.atiusamy.com/notes/9uz3qie07fdf0aqr :

{
  "@context": "...",
  "type": "Note",
  "id": "https://social.atiusamy.com/notes/9uz3qie07fdf0aqr",
  "attributedTo": "https://social.atiusamy.com/users/9p9rv1xudh4b0001",
  "content": "<p>I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post. I am testing a funny and long post.</p>",
  "published": "2024-06-26T07:52:18.840Z",
  "to": ["https://www.w3.org/ns/activitystreams#Public"],
  "cc": ["https://social.atiusamy.com/users/9p9rv1xudh4b0001/followers"],
  "inReplyTo": null,
  "attachment": [],
  "sensitive": false,
  "tag": []
}

Some fediverse servers do conneg and serve HTML to id URLs, but not all - Threads is one example - and AP doesn't require it. So, if url isn't available, I could link to id, but I'm reluctant to.

Having said that, omitting url is rare, so maybe it's worth falling back to id in those cases. 🤷

snarfed added a commit to snarfed/granary that referenced this issue Jun 26, 2024
@snarfed
Copy link
Owner

snarfed commented Jun 26, 2024

Falling back to id in these cases seems reasonable. We may send some people to ugly AS2 JSON, but that's probably an acceptable cost. Done!

@snarfed snarfed closed this as completed Jun 26, 2024
@AtiusAmy
Copy link
Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants