Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP: optimize outbox handler #1152

Open
snarfed opened this issue Jun 25, 2024 · 2 comments
Open

AP: optimize outbox handler #1152

snarfed opened this issue Jun 25, 2024 · 2 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jun 25, 2024

We cache these, but still, they're way too slow right now!
snarfed added a commit that referenced this issue Jun 26, 2024
@snarfed
AP: harden outbox and followers/ing collections to only count up to a…
85d85d1 
… limit

we should eventually precompute them so we can always return them cheaply!

for #1152
@snarfed
Copy link
Owner Author

snarfed commented Jun 26, 2024

First step ^ was hardening the totalItems counts for posts and followers/followees. That helped some, but not enough on its own. Next step is probably to stop hydrating actors.
@snarfed
Copy link
Owner Author

snarfed commented Jun 26, 2024 •
edited
Loading

Hmm, interesting, we hydrate actors in followers/ing but not outbox. Notably though, we batch those actor datastore fetches in followers/ing, and we do ActivityPub.convert individually for each object in outbox, which may incur multiple datastore fetches.
@snarfed snarfed mentioned this issue Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@snarfed