Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new Cookies (issue #94) #97

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Added 2 new Cookies (issue #94) #97

merged 3 commits into from
Apr 18, 2024

Conversation

franciscawijaya
Copy link
Member

I have added the new cookie names to regex.js, added new columns for the collection of database for cookies in the rest-api file, and added a few lines of code in the analysis.js file (under the LogData function to collect and store to the database through the analysis__userend[domain] for both cookies (both for before and after GPC).

@franciscawijaya
Copy link
Member Author

Updated the analsis.js file in the second commit from the previous commit. Tried to repackage the extension into xpi file but there was a problem with the npm run build command.
When running npm run build, received this message:
"rimraf disst && mkdir dist &7 mkdir dist/packages
rimraf: command not found"

Troubleshooting:
Since "npm run build" presumably build/prep tasks that we specify from the package.json file before being used in another project (which in this case would be the /dist/firefox directory including files like the manifest.json), this message suggests that the rimraf command (that is used to safely remove file and folders on all platforms) might be the missing dependency in the package.json file.
However, in line 9 of the package.json, "prestart": "rimraf dev" is written. So, to repackage it successfully, I need to install rimraf command locally.

Screenshot 2024-03-31 at 3 07 31 AM

@SebastianZimmeck
Copy link
Member

Updated the analsis.js file in the second commit from the previous commit. Tried to repackage the extension into xpi file but there was a problem with the npm run build command.

Do you need to run npm install first?

@franciscawijaya
Copy link
Member Author

Yes! I found out I had to install rimraf locally becausse I think when I was setting it up last time I did not run npm install because I didn't need to run the crawler yet. Thank you! I have now successfully repackaged it and will make new commit.

@katehausladen katehausladen merged commit 81855cc into main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants