Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check over Architecture ReadMe #408

Closed
OliverWang13 opened this issue Mar 1, 2023 · 3 comments
Closed

Check over Architecture ReadMe #408

OliverWang13 opened this issue Mar 1, 2023 · 3 comments
Assignees
@OliverWang13 @sophieeng
Labels
architecture Design of codebase

Comments

@OliverWang13
Copy link
Collaborator

This should be the last thing we do before releasing, to ensure everything looks as desired.
@OliverWang13 OliverWang13 added the architecture Design of codebase label Mar 1, 2023
@OliverWang13
Copy link
Collaborator Author

Additionally, update the method of adding and removing the dom signal, if that is included in the architecture ReadMe
@SebastianZimmeck
Copy link
Member

Additionally, update the method of adding and removing the dom signal, if that is included in the architecture ReadMe

That would be good. And also check if there is other documentation that needs to be updated in that regard, e.g., code comments, wiki, ...
sophieeng added a commit that referenced this issue Mar 24, 2023
@sophieeng
Small formatting changes (issue #408)
446154f
OliverWang13 added a commit that referenced this issue Mar 25, 2023
@OliverWang13
Updated architecture readme (Issue #408)
5eec891
OliverWang13 added a commit that referenced this issue Mar 25, 2023
@OliverWang13
Small architecture switch (Issue #408)
ddaff86
@OliverWang13
Copy link
Collaborator Author

This looks good, so I will be closing this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Design of codebase
3 participants
@SebastianZimmeck @OliverWang13 @sophieeng