Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix makeCoookieIAB.test.js #398

Closed
sophieeng opened this issue Dec 28, 2022 · 1 comment
Closed

Fix makeCoookieIAB.test.js #398

sophieeng opened this issue Dec 28, 2022 · 1 comment
Assignees
@sophieeng
Labels
testing Accuracy, performance, or other testing issue

Comments

@sophieeng
Copy link
Collaborator

This test asks for the current time but there can be rounding errors when comparing it to the makeCookieIAB function which needs the time for an expiration date. Talking in the group meeting with Kate, we agree that it's best to remove the time comparison because of the likelihood it will cause errors in the CI and because the time is not critical to the actual function.
@sophieeng sophieeng added the testing Accuracy, performance, or other testing issue label Dec 28, 2022
@sophieeng sophieeng self-assigned this Dec 28, 2022
sophieeng added a commit that referenced this issue Dec 28, 2022
@sophieeng
Remove date comparison (issue #398)
c0ba067
katehausladen added a commit that referenced this issue Dec 28, 2022
@katehausladen
Merge pull request #399 from privacy-tech-lab/issue-398
dc50777 
Remove date comparison (issue #398)
@sophieeng
Copy link
Collaborator Author

Merged and closing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Accuracy, performance, or other testing issue
1 participant
@sophieeng