Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idle Detection API harmful #560

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Idle Detection API harmful #560

merged 2 commits into from
Aug 2, 2021

Conversation

tantek
Copy link
Member

@tantek tantek commented Jul 30, 2021 •
edited
Loading

Closes #453
annevk
annevk approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay modulo nit. The link in the position detail could also be made with markup as we have done elsewhere (though mostly for inline links thus far I think), resulting in a better user experience.
activities.json Outdated Show resolved Hide resolved
martinthomson
martinthomson reviewed Aug 2, 2021
View reviewed changes
activities.json Outdated Show resolved Hide resolved
@martinthomson @annevk
Minor edits
09129a4 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@martinthomson martinthomson merged commit 9d3ee57 into main Aug 2, 2021
@martinthomson martinthomson deleted the tantek-patch-1 branch August 2, 2021 23:27
@zer zer mentioned this pull request Sep 28, 2021
Closed
Daasin pushed a commit to Daasin/standards-positions that referenced this pull request Jan 5, 2023
@tantek @martinthomson
@annevk @Daasin
Idle Detection API harmful (mozilla#560)
205170c 
* Idle Detection API harmful

* Minor edits

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@tantek @martinthomson @annevk