Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GDPR annotations #34997

Merged
merged 39 commits into from
Sep 26, 2017
Merged

Adding GDPR annotations #34997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
72dfa6c
classify common properties
kieferrm Sep 4, 2017
858d465
first batch events
kieferrm Sep 4, 2017
02b6db0
gdpr tooling
kieferrm Sep 4, 2017
94667ec
update snippets
kieferrm Sep 5, 2017
8671fe5
parse source comments
kieferrm Sep 6, 2017
d1e4c64
fix GDPR value
kieferrm Sep 7, 2017
0be8478
remove unused files
kieferrm Sep 7, 2017
cc1255c
more GDPR classification
kieferrm Sep 8, 2017
370f1e7
fix typo
kieferrm Sep 8, 2017
b059271
fix typo
kieferrm Sep 8, 2017
d821c08
fix typo
kieferrm Sep 8, 2017
ca8b412
more GDPR classification
kieferrm Sep 8, 2017
c28edb3
more GDPR classification
kieferrm Sep 8, 2017
7ee4c75
correct typos
kieferrm Sep 8, 2017
e1c04e5
more GDPR classification
kieferrm Sep 8, 2017
fb2da69
correct typos
kieferrm Sep 8, 2017
4f873b7
correct property names
kieferrm Sep 8, 2017
d54487e
replace invalid value
kieferrm Sep 8, 2017
fcd85f4
inline values
kieferrm Sep 9, 2017
f885522
change wildcard property
kieferrm Sep 12, 2017
1d7b0a2
use wildcard for files.joined
kieferrm Sep 12, 2017
f691cfe
classification for TS extension
kieferrm Sep 18, 2017
9cceab0
gdpr classification for markdown extension
kieferrm Sep 18, 2017
47000c3
GDPR classification for git extension
kieferrm Sep 19, 2017
f0e9b12
GDPR classification for save participants
kieferrm Sep 19, 2017
b4c594a
GDPR classify timer2 on IStartupMetrics
kieferrm Sep 19, 2017
da1fc46
review GDPR classifications
kieferrm Sep 19, 2017
8550b03
correct wildcard usage
kieferrm Sep 19, 2017
dca73b7
omit endPoint where it defaults to none
kieferrm Sep 20, 2017
15e6a82
GDPR comments
kieferrm Sep 23, 2017
8d48ed8
update GDPR todos
kieferrm Sep 25, 2017
146f868
fixing classification
kieferrm Sep 25, 2017
d5604cf
update extension install, update and uninstall events
kieferrm Sep 25, 2017
905eca3
add description for new common property
kieferrm Sep 25, 2017
15a5efc
formatting change
kieferrm Sep 25, 2017
3c70c36
indentation changes
kieferrm Sep 25, 2017
955adbf
add missing commas
kieferrm Sep 26, 2017
5aa3360
fix typos
kieferrm Sep 26, 2017
112f9a5
fix searchResultsShown event
kieferrm Sep 26, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typos
  • Loading branch information
@kieferrm
kieferrm committed Sep 26, 2017
commit 5aa3360690d0c029520b17aafe8e17c93aac1363
2 changes: 1 addition & 1 deletion src/vs/platform/telemetry/node/commonProperties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function resolveCommonProperties(commit: string, version: string, source:
result['version'] = version;
// __GDPR__COMMON__ "common.osVersion" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
result['common.osVersion'] = os.release();
// __GDPR__COMMON__ "common.platfrom" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
// __GDPR__COMMON__ "common.platform" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
result['common.platform'] = Platform.Platform[Platform.platform];
// __GDPR__COMMON__ "common.nodePlatform" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
result['common.nodePlatform'] = process.platform;
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {

return this.promptAndSetEnablement(extension, enable, workspace).then(reload => {
/* __GDPR__
"extension:enabled" : {
"extension:enable" : {
"${include}": [
"${GalleryExtensionTelemetryData}"
]
Expand Down