Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node 20 in dev container #215434

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Use node 20 in dev container #215434

merged 1 commit into from
Jun 13, 2024

Conversation

dangerman
Copy link
Contributor

@dangerman dangerman commented Jun 13, 2024 •
edited
Loading

Fixes #215432

Before After
image image

Running yarn install requires node 20, but our typescript dev container base image uses node 18.

This PR just updates it to typescript-node:20-bookworm

Tests

I've run the following in my dev container, and it seems to work fine.

  • ESLint (yarn eslint)
  • Unit tests (./scripts/test.sh)
  • Automated smoke tests (yarn smoketest)
@dangerman dangerman marked this pull request as ready for review June 13, 2024 12:28
chrmarti
chrmarti approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!
@chrmarti chrmarti enabled auto-merge (rebase) June 13, 2024 13:53
@VSCodeTriageBot VSCodeTriageBot added this to the June 2024 milestone Jun 13, 2024
@chrmarti chrmarti merged commit e857686 into microsoft:main Jun 13, 2024
6 checks passed
@dangerman dangerman deleted the fix-215432-use-node-20-dev-container branch July 24, 2024 09:32
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@dangerman @TylerLeonhardt @chrmarti @VSCodeTriageBot