-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ko] Set() 생성자 신규 번역, Set 설명 추가 #22061
Conversation
- Set() 생성자 신규 번역 - 기존 yari 렌더링 문제로 추가하지 못했던 `Set composition`이 추가됨
Preview URLs
Flaws (7)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2024-07-08 22:18:15) |
@caugner Hello! ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생 많으셨습니다~! 아래 한가지 리뷰사항 제안 드립니다.
좋은 하루 보내세요 :)
|
||
- `iterable` {{optional_inline}} | ||
|
||
- : [순회 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- : [순회 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다. | |
- : [순회 가능한 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다. |
iterable object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Unfortunately, it is a known issue that the preview does not render images that belong to a different page that hasn't been modified in the same PR. @yin1999 I believe you noticed this before. Do you remember if you opened an issue in yari? |
The previously opened issue does not seem to be this. I believe the issue in the current PR is related to this line: https://github.com/mdn/yari/blob/58353d37287a3e9d596a4d002eb4c08e5ae8cae3/build/check-images.ts#L156 This line only considers the case where the image file is directly in the folder where the current document is located. Actually, we should get the relative path instead of the |
@yin1999 , Um... I see. Thank you. I won't create a issue on yari, but I'll note it. |
Set composition
이 추가됨Geek News에서 JavaScript 의 새로운 Set 메소드들이 소개되면서 Set 신규 추가를 홍보하기에 노 저어봅니다.