Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Set() 생성자 신규 번역, Set 설명 추가 #22061

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

wisedog
Copy link
Contributor

@wisedog wisedog commented Jun 29, 2024

  • Set() 생성자 신규 번역
  • 기존 yari 렌더링 문제로 추가하지 못했던 Set composition이 추가됨

Geek News에서 JavaScript 의 새로운 Set 메소드들이 소개되면서 Set 신규 추가를 홍보하기에 노 저어봅니다.

- Set() 생성자 신규 번역
- 기존 yari 렌더링 문제로 추가하지 못했던 `Set composition`이 추가됨
@wisedog wisedog requested a review from a team as a code owner June 29, 2024 06:02
@wisedog wisedog requested review from hochan222 and removed request for a team June 29, 2024 06:02
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jun 29, 2024
Copy link
Contributor

github-actions bot commented Jun 29, 2024

Preview URLs

Flaws (7)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Set
Title: Set
Flaw count: 7

  • macros:
    • /ko/docs/Web/API/GPUSupportedFeatures does not exist but fell back to /en-US/docs/Web/API/GPUSupportedFeatures
    • /ko/docs/Web/API/GPUSupportedFeatures does not exist but fell back to /en-US/docs/Web/API/GPUSupportedFeatures
    • /ko/docs/Web/API/XRAnchorSet does not exist but fell back to /en-US/docs/Web/API/XRAnchorSet
    • /ko/docs/Web/API/CustomStateSet does not exist but fell back to /en-US/docs/Web/API/CustomStateSet
    • /ko/docs/Web/API/FontFaceSet does not exist but fell back to /en-US/docs/Web/API/FontFaceSet
    • and 2 more flaws omitted
External URLs (1)

URL: /ko/docs/Web/JavaScript/Reference/Global_Objects/Set/Set
Title: Set() 생성자

(comment last updated: 2024-07-08 22:18:15)

@hochan222
Copy link
Member

@caugner Hello!
It seems to be exposed well in the production environment(may be..?), but I don't know what the problem is in the preview link, but the image is not displayed. It would be nice if it could be improved in the future. (or bug..?)

image
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~! 아래 한가지 리뷰사항 제안 드립니다.

좋은 하루 보내세요 :)


- `iterable` {{optional_inline}}

- : [순회 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- : [순회 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다.
- : [순회 가능한 객체](/ko/docs/Web/JavaScript/Reference/Statements/for...of)가 전달되면 모든 요소가 새로운 `Set`에 추가됩니다.

iterable object

@wisedog wisedog requested a review from hochan222 July 8, 2024 22:19
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 2f752b6 into mdn:main Jul 9, 2024
7 checks passed
@wisedog wisedog deleted the js/set-index-cntr branch July 9, 2024 07:56
@caugner
Copy link
Contributor

caugner commented Jul 9, 2024

@caugner Hello!
It seems to be exposed well in the production environment(may be..?), but I don't know what the problem is in the preview link, but the image is not displayed. It would be nice if it could be improved in the future. (or bug..?)

Unfortunately, it is a known issue that the preview does not render images that belong to a different page that hasn't been modified in the same PR.

@yin1999 I believe you noticed this before. Do you remember if you opened an issue in yari?

@yin1999
Copy link
Member

yin1999 commented Jul 9, 2024

@caugner Hello!
It seems to be exposed well in the production environment(may be..?), but I don't know what the problem is in the preview link, but the image is not displayed. It would be nice if it could be improved in the future. (or bug..?)

Unfortunately, it is a known issue that the preview does not render images that belong to a different page that hasn't been modified in the same PR.

@yin1999 I believe you noticed this before. Do you remember if you opened an issue in yari?

The previously opened issue does not seem to be this. I believe the issue in the current PR is related to this line:

https://github.com/mdn/yari/blob/58353d37287a3e9d596a4d002eb4c08e5ae8cae3/build/check-images.ts#L156

This line only considers the case where the image file is directly in the folder where the current document is located.

Actually, we should get the relative path instead of the basename (filename only) for the images in other paths (that is, not only the locale is different. e.g. /ko/docs/Web/JavaScript/Reference/Global_Objects/Set/difference againsts /ko/docs/Web/JavaScript/Reference/Global_Objects/Set).

@hochan222
Copy link
Member

@yin1999 , Um... I see. Thank you.

I won't create a issue on yari, but I'll note it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
4 participants