-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mention that not
must be used with media type
#34509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this.
Just one comment: There's a phrase Idon't fully understand.
@@ -180,7 +180,7 @@ The `and` operator can also combine multiple media features into a single media | |||
The `only` operator prevents older browsers from applying the styles. | |||
|
|||
> **Note:** In most cases, the `all` media type is used by default when no other type is specified. | |||
> However, if you use the `not` or `only` operators, you must explicitly specify a media type. | |||
> However, if you use the `only` operator, you must explicitly specify a media type. You can see `only screen` or `only print` as a whole. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what "as a whole" means here. Line 180 likely needs to be updated and congruent with this intended content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant: you can see only screen
and only print
as if it's a media type as a whole. This is because only (screen)
or only (screen and (width < 100px))
don't work either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Fix #32320