Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the experimental note for masonry-layout and added removal fo… #34280

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jun 20, 2024

Description

  • removed experimental note on Masonry grid layout
  • added align-tracks & justify-tracks to the CSS remove on the 128 release page

Motivation

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner June 20, 2024 08:22
@dletorey dletorey requested review from hamishwillee and removed request for a team June 20, 2024 08:22
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Preview URLs

External URLs (77)

URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-06-20 12:37:59)

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the experimental features entry, I can still see the layout.css.grid-template-masonry-value.enabled flag in 129, and it’s enabled by default. I believe we’re only removing two properties that were dropped from the spec. The rest of the masonry implementation stays for now.

@dletorey dletorey requested a review from pepelsbey June 20, 2024 10:22
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s also keep the “Masonry grid layout” entry on the experimental features page, too. It’s still there for now and enabled by default.

files/en-us/mozilla/firefox/releases/128/index.md Outdated Show resolved Hide resolved
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you :)

@pepelsbey pepelsbey merged commit a229786 into mdn:main Jun 20, 2024
8 checks passed
@dletorey dletorey deleted the 33989-remove-support-for-a-j-tracks-ff-release branch July 3, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
2 participants