Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF126 Relnote: CustomStateSet and CSS :state() selector #33098

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

hamishwillee
Copy link
Collaborator

FF126 supports CustomStateSet and the CSS :state() selector in https://bugzilla.mozilla.org/show_bug.cgi?id=1887543. This adds a release note and strips the info from Experimental features.

Related docs work can be tracked in #33018

@hamishwillee hamishwillee requested a review from a team as a code owner April 15, 2024 06:46
@hamishwillee hamishwillee requested review from dipikabh and removed request for a team April 15, 2024 06:46
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

Preview URLs

External URLs (74)

URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-04-22 01:51:15)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the release note update, @hamishwillee.
It's looking good overall, but I've got a few questions.

files/en-us/mozilla/firefox/releases/126/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/126/index.md Outdated Show resolved Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@hamishwillee
Copy link
Collaborator Author

Thanks @dipikabh , I accepted your changes/suggestions.

Just FYI I added notes in response - essentially I'm not sure the patterns we use for adding bugs or for marking things that were previously behind pref are actually useful for anyone. But there you are :-)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hamishwillee, for your updates and comments (I've responded inline). Leaving a +1 so you can merge later should you want to make any adjustments.

@hamishwillee
Copy link
Collaborator Author

Thanks very much @dipikabh !

@hamishwillee hamishwillee merged commit ca46bb9 into mdn:main Apr 22, 2024
8 checks passed
@hamishwillee hamishwillee deleted the ff126_custom_states_elements branch April 22, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Firefox 126 size/s [PR only] 6-50 LoC changed
3 participants