Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental h1 UA styles removal #33020

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Conversation

pepelsbey
Copy link
Member

Description

  • Adds experimental h1 UA styles removal info into Firefox 125 release notes and to the Experimental features page
  • Fixes headings levels for two other experimental features: they seem to be not grouped.

Motivation

Upcoming Firefox 125 release.

Additional details

Related issues and pull requests

@pepelsbey pepelsbey requested review from dipikabh and bsmth April 9, 2024 17:38
@pepelsbey pepelsbey requested a review from a team as a code owner April 9, 2024 17:38
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Apr 9, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview URLs

External URLs (5)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox


URL: /en-US/docs/Mozilla/Firefox/Releases/125
Title: Firefox 125 for developers

(comment last updated: 2024-04-16 10:11:19)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Vadim!
I have a few questions and suggestions.

Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's close and getting better, thanks for the clarifications!

pepelsbey and others added 3 commits April 15, 2024 11:52
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@pepelsbey pepelsbey requested a review from dipikabh April 15, 2024 10:05
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @pepelsbey! Approving.

Note:

  • @zcorpan's comment needs to be fixed because of the table header change back to the previous one based on my suggestion but pref behavior is reverse. Sorry for the mix up
  • Text changes need to be replicated to firefox/releases/125/index.md file as well.
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Apr 16, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Apr 16, 2024
@pepelsbey
Copy link
Member Author

zcorpan's comment needs to be fixed
text changes need to be replicated to firefox/releases/125/index.md file as well.

Done and done. Thank you both!

@pepelsbey pepelsbey merged commit ffae49a into mdn:main Apr 16, 2024
8 checks passed
@pepelsbey pepelsbey deleted the nested-h1-ua-styles branch April 16, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Firefox 125 size/m [PR only] 51-500 LoC changed
3 participants