-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📅 12/26 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part VII) #60
Comments
Going live in 30 minutes at https://twitch.tv/gregorcodes |
I'm now live on https://twitch.tv/gregorcodes |
All done for today! Recording will be available here in a moment: |
Time for a new episode? :D |
it is! I'm sorry, we had a complex move over new years and the first weeks of January, got COVID (luckily only mild symptoms, our kids are high-risk ...), and are house hunting now, it's all very exhausting. But I will get back to it, I will finish up this work. We have one final move next week for now, and then I hope that by mid February I'll find time to do Sunday shows again |
Well, take care, stay safe! I hope everything goes well. |
💁🏻 Refactoring a 10+ years old code base: nock (Part VII)
📅 Sunday, December 26, 2021
🕐 12:00am Pacific Time
🎙️ no guests
📍 https://www.twitch.tv/gregorcodes
🏷️ opensource
Subscribe to this issues to get a notification before the show begins and a summary after the show concludes.
Refactoring a 10+ years old code base: nock (Part VII)
I will continue my refactoring work from the first 6 weeks: #59, #58, #55, #54, #53
We use the new module throughout nock's code base now. Unfortunately some tests are still failing, so that's what I hope to finish in this session.
If we get all existing tests to pass and reach 100% test coverage again, I'll move the internal intercept module to its own repository and publish it as its own npm module.
Outline
tests/test_recorder.js
tests/test_back_filters.js
tests/test_back.js
URL
api to parse a request string and make sure we set all the properties. Have another look at what the nativehttp.RequestClient
api is doing.nock
codebase. Remove no longer used code and obsolete tests.nock/intercept
repository and move the internal module therenock
TODOs
Before the show
(https://twitter.com/gr2m/status/1475187516277936131)
(📅 12/26 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part VII) #60 (comment))
When show begins
(https://twitter.com/gr2m/status/1475194342516035588)
(📅 12/26 @ 12:00pm PT - Refactoring a 10+ years old code base: nock (Part VII) #60 (comment))
(https://twitter.com/gr2m)
After the show
Recording
https://www.twitch.tv/videos/1244301943
Shownotes
nock/nock#2247 (comment)
The text was updated successfully, but these errors were encountered: