Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR - added a new url for vs code #33927

Closed
wants to merge 1 commit into from
Closed

PR - added a new url for vs code #33927

wants to merge 1 commit into from

Conversation

leandromsft
Copy link
Contributor

Why:

This pull request introduces a minor change to the troubleshooting-firewall-settings-for-github-copilot.md file. The change adds a new URL https://vscode.dev to the list of URLs that may require allowlisting for GitHub Copilot. This URL is used when logging in with GitHub or Microsoft for an extension or Settings Sync.

When a VS Code user is configuring the GH Copilot plugin, when authentication is completed, the user is redirected to a URL similar to the one below

https://github.com/login/oauth/authorize?client_id=XXXX&redirect_uri=https://vscode.dev/redirect&......

If the user is behind a firewall/proxy, needs to allow the vscode.dev url to complete authentication.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/troubleshooting-github-copilot/troubleshooting-firewall-settings-for-github-copilot.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Jul 10, 2024
@nguyenalex836
Copy link
Contributor

@leandromsft Thanks so much for opening a PR! I'll get this triaged for review ✨
@jules-p
Copy link
Contributor

jules-p commented Jul 18, 2024

Hi @leandromsft 👋 thank you for contributing a suggestion to the GitHub docs. I have chatted with the Copilot team, and we won't be able to accept this change at this time, but we will discuss internally whether any additional changes should be made to the article. Thank you again for being part of the docs open source community ✨
@jules-p jules-p closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot waiting for review Issue/PR is waiting for a writer's review
3 participants
@leandromsft @nguyenalex836 @jules-p