Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messaging] Remove extraneous const on FIRMessagingIsAPNSSyncMessage #13245

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

andrewheard
Copy link
Contributor

Removed an extraneous const on the BOOL return type of FIRMessagingIsAPNSSyncMessage(...) to resolve a warning surfaced with internal tooling:

return type 'const BOOL' (aka 'const bool') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness

https://clang.llvm.org/extra/clang-tidy/checks/readability/const-return-type.html

#no-changelog

@andrewheard andrewheard requested a review from ncooke3 July 8, 2024 22:51
@andrewheard
Copy link
Contributor Author

The messaging / spm (macos-14, visionOS, Xcode_15.3) job is already failing on main; ignoring.

@andrewheard andrewheard merged commit 28612c6 into main Jul 10, 2024
58 of 59 checks passed
@andrewheard andrewheard deleted the ah/messaging-const branch July 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants