Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make memory lru gc the default #12692

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Make memory lru gc the default #12692

merged 7 commits into from
Jul 11, 2024

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 3, 2024

No description provided.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (ed28962) to 88.12% (971706b) by -0.07%.

    FilenameBase (ed28962)Merge (971706b)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.43%98.82%+0.39%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    task.cc94.78%93.91%-0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Nod3iYJUxv.html
@wu-hui wu-hui requested review from ncooke3 and ehsannas July 11, 2024 15:05
@wu-hui wu-hui requested review from paulb777 and removed request for ncooke3 July 11, 2024 15:13
@wu-hui wu-hui assigned paulb777 and unassigned ncooke3 Jul 11, 2024
paulb777
paulb777 approved these changes Jul 11, 2024
View reviewed changes
Firestore/CHANGELOG.md Show resolved Hide resolved
ehsannas
ehsannas approved these changes Jul 11, 2024
View reviewed changes
Firestore/core/src/api/settings.h Show resolved Hide resolved
@wu-hui wu-hui merged commit 96890a3 into main Jul 11, 2024
34 checks passed
@wu-hui wu-hui deleted the wuandy/MemoryLruDefault branch July 11, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore
5 participants
@wu-hui @google-oss-bot @paulb777 @ehsannas @ncooke3