Add advanced BP theme supports checks #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonascalves
requested changes
May 31, 2024
imath
force-pushed
the
add/bp-theme-features
branch
from
048a90c
to
807e633
Compare
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 3, 2024
Some of the feature we'll soon introduce like the Block based activity post form will need standalone BP themes to do some adjustments to their code to support them. Once done, they'll need to opt-in for these features using the WordPress `add_theme_support()` function. The first argument for this function remains `buddypress`. Supporting BP component specific features will need to use a second argument: an associative array keyed by BP Component IDs. For instance, it will be `array( 'activity' => array( 'block-editor' ) )` when a theme support the future Block based activity post form. In BuddyPress code, we'll then be able for example to use the following kind of check `bp_current_theme_supports( array( 'activity' => 'block-editor' ) )` to be sure the theme fully support the feature. Props espellcaste See #8319 Closes buddypress/buddypress#301 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13912 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extending the WP theme supports API to be able to check Standalone themes opted in for BP Modern features such as the Activity Block Editor.
Usage in theme:
Usage in BuddyPress:
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8319
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.