Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 80.0.3987.149 to Chromium 81.0.4044.69. #4548

Merged
merged 89 commits into from
Mar 20, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
ff62227
Update patches from Chromium 80.0.3987.149 to Chromium 81.0.4044.69.
mkarolin Feb 5, 2020
2badd6e
[Android] Toolbar corner radius patch moved.
mkarolin Feb 5, 2020
276c3e4
[Android] MainPreferences -> MainSettings patch.
mkarolin Feb 5, 2020
5877a78
[Android] Website preferences renamed.
mkarolin Feb 5, 2020
29ce63b
[Android] chrome_feature_list.cc moved.
mkarolin Feb 5, 2020
24f70b8
permission_request.h, permission_util.h/cc, etc. moved.
mkarolin Feb 5, 2020
48336cc
PermissionDescriptorToPermissionType was moved.
mkarolin Feb 7, 2020
a5cd331
theme_service_win -> theme_helper_win.
mkarolin Feb 6, 2020
ed3cc74
settings_import_data_handler -> import_data_handler.
mkarolin Feb 6, 2020
f2777db
components/safe_browsing rearranged.
mkarolin Feb 6, 2020
14662a6
resource_ids -> resource_ids.spec
mkarolin Feb 6, 2020
a0029db
Shuffled components_*_strings.grd entries in resource_ids.spec.
mkarolin Feb 7, 2020
255b51b
Renamed build output in brave/network/public/cpp.
mkarolin Feb 6, 2020
5ea9e1d
ScriptPromiseProperty was simplified.
mkarolin Feb 6, 2020
5495918
Use base::Value::Append for lists.
mkarolin Feb 6, 2020
1f3bde6
Use base::Value::EraseListValue.
mkarolin Feb 6, 2020
d980314
CreateSpecificsFromBookmarkNode signature changed.
mkarolin Feb 6, 2020
56f6c2c
static AutocompleteMatch::AllowedToBeDefault became a member.
mkarolin Feb 6, 2020
ab06fd9
Use comment instead of <if> in html patch.
mkarolin Feb 6, 2020
ae33d0f
Fixes AvatarToolbarButton.
mkarolin Feb 7, 2020
a6558e8
PostTaskAndReplyWithResult takes OnceCallbacks.
mkarolin Feb 9, 2020
34a4293
BindInt(64) require exact type.
mkarolin Feb 9, 2020
5c5afd2
session_tab_helper has moved.
mkarolin Feb 10, 2020
bcccb05
SandboxedUnpacker base::Value usage changed.
mkarolin Feb 10, 2020
bef3118
base::CurrentThread has been removed.
mkarolin Feb 10, 2020
b7a4b91
extensions::UnloadedExtensionReason has moved.
mkarolin Feb 10, 2020
8cbfc7e
components_ui.h has moved.
mkarolin Feb 12, 2020
6e7c0ee
network::ResourceResponse has been removed.
mkarolin Feb 12, 2020
f955eba
SyncService::DisableReason is now an EnumSet.
mkarolin Feb 12, 2020
626f95e
components/safe_browsing was reorganized.
mkarolin Feb 12, 2020
e09e6ea
kAlternateErrorPagesAllowed pref was componetized.
mkarolin Feb 12, 2020
3710bb4
ResourceLoadInfo::url -> final_url.
mkarolin Feb 12, 2020
267451b
Use DialogDelegate::set_button_label.
mkarolin Feb 12, 2020
6b99aea
ResourceRequest::site_for_cookies has its own type now.
mkarolin Feb 12, 2020
77361dc
Re-added AdjustUtilityServiceProcessCommandLine to ContentBrowserClient.
mkarolin Feb 12, 2020
4be1599
WillCreateURLLoaderFactory signature change.
mkarolin Feb 12, 2020
691d86a
Re-added a global on-demand component updater function.
mkarolin Feb 13, 2020
00a088e
TranslateIconView c'tor signature change.
mkarolin Feb 13, 2020
27a51f7
Updated url_constants.cc override.
mkarolin Feb 13, 2020
83cf96b
Revert "Merge pull request #4092 from fow5040/add-extra-static-zoom-l…
mkarolin Feb 13, 2020
854dc28
Restored custom zoom values.
mkarolin Feb 13, 2020
a34451d
Moved br_toolbar's link stylesheet entries.
mkarolin Feb 14, 2020
2577713
Polymer 3 fixes for history page.
mkarolin Feb 14, 2020
641ec7b
[Linux] Upstream fix for vappi with GLX.
mkarolin Feb 14, 2020
cd0ec9e
[Linux] Upstream fix for cros_supported_configs_.
mkarolin Feb 15, 2020
065a151
[Unit test] Removed unused header include.
mkarolin Feb 17, 2020
0a48edc
[Unit test] RegisterContentSchemes signature change.
mkarolin Feb 17, 2020
c8bd2d1
[Browser Test] BROWSER_TEST_WAIT_FOR_NAVIGATION -> BROWSER_TEST_WAIT_…
mkarolin Feb 18, 2020
dcea28a
[Browser Test] PermissionRequestManager::GetBubbleView was removed.
mkarolin Feb 18, 2020
fb6d0cc
Fixes build of third_party/devtools-frontend/src.
mkarolin Feb 18, 2020
b9e85c4
Settings UI: diceEnabled was removed.
mkarolin Feb 19, 2020
9c9350d
Settings UI: router is now a singleton.
mkarolin Feb 19, 2020
d4c677e
Settings UI: Anchor autofill section to languages section.
mkarolin Feb 19, 2020
8813742
Settings UI: use relative path for autoimport of CrSearchFieldBehavior.
mkarolin Feb 19, 2020
e299d39
GCMChannelStatusSyncer was removed.
mkarolin Feb 8, 2020
6055420
BitmapFetcherService::RequestImage now takes a callback.
mkarolin Feb 10, 2020
0ea10ad
Fixes profile menu.
mkarolin Feb 13, 2020
2498bdf
page_action_icon_container_view.cc -> page_action_icon_controller.cc.
mkarolin Feb 25, 2020
3221538
Disables blink::features::kTextFragmentAnchor
mkarolin Feb 26, 2020
b4eec4b
Fixes DCHECK crash when closing Tor window.
mkarolin Feb 27, 2020
f33a35e
Removed os_crypt_mac.mm patch.
mkarolin Feb 28, 2020
9c1c805
Patches notifications os version check on Mac.
mkarolin Mar 2, 2020
9d2f803
Settings UI: fixes privacy page.
mkarolin Mar 2, 2020
d967be1
[Android] Privacy settings renamed.
mkarolin Mar 4, 2020
341746f
Removed cookie_settings_base.cc override.
mkarolin Mar 4, 2020
01b93e6
Migrate shield settings.
mkarolin Mar 7, 2020
9224d7d
Lint fixes.
mkarolin Mar 10, 2020
9eccf0c
[Android] HomePagePreferences -> HomePageSettings.
mkarolin Mar 13, 2020
b1db1b3
[Android] NotificationsPreferences -> NotificationsSettings.
mkarolin Mar 13, 2020
74fbfca
[Android] Removed AutofillAssistantPreferences patch.
mkarolin Mar 13, 2020
20d9147
[Android] DownloadPreferences -> DownloadSettings.
mkarolin Mar 13, 2020
a193bc4
[Android] SavePasswordsPreferences -> PasswordSettings.
mkarolin Mar 13, 2020
357603d
[Android] Sync preferences renamed.
mkarolin Mar 13, 2020
53ab6c6
[Android] Theme preferences renamed.
mkarolin Mar 13, 2020
0a6c65f
Added new languages to fix build
samartnik Mar 16, 2020
49c6ed6
[Android] Added new resources to fix build
samartnik Mar 16, 2020
d414811
[Android] Fixed build issues related to renaming in Chromium
samartnik Mar 16, 2020
c28b1a8
[Android] Fixes for build errors
samartnik Mar 16, 2020
3c58366
Updated strings for 81.0.4044.34.
mkarolin Feb 6, 2020
bef1469
Don't subclass ThemeService anymore
simonhong Mar 17, 2020
6522e53
Migrate shield settings: code review fixes.
mkarolin Mar 18, 2020
f9d3dfd
Use BindInt64 instead of static_cast<int>
mkarolin Mar 19, 2020
c281afe
Remove unneeded dep in brave_generated_resources_grit.
mkarolin Mar 19, 2020
44aaeb9
use AppendExtraCommandLineSwitches as temporary workaround for Tor ex…
bridiver Mar 19, 2020
65703bc
[Android] Fixed build for the latest master
samartnik Mar 20, 2020
e10a013
[Android] Added brave-sync-android to ignore list
samartnik Mar 20, 2020
6b81cc1
use BraveOnDemandUpdater for brave code
bridiver Mar 20, 2020
5782614
Simplify theme changes for cr81.
mkarolin Mar 20, 2020
2c0b36d
Added comments for use of BindInt64.
mkarolin Mar 20, 2020
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disables blink::features::kTextFragmentAnchor
Fixes brave/brave-browser#8342

Chromium change:

https://chromium.googlesource.com/chromium/src/+/62f8d5f096b174d05cd7f716585983df483024d7

commit 62f8d5f096b174d05cd7f716585983df483024d7
Author: Nick Burris <nburris@chromium.org>
Date:   Thu Jan 16 22:54:51 2020 +0000

    Enable Scroll To Text by default

    Enables scroll to text by default for M81. Note we plan to launch via
    Finch for M80.

    Intent to ship with LGTMs:
    https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ

    This patch also updates web platform test expectations:
    - scroll-to-text-fragment.html now passes; it just needed an extra rAF
      for the fallback to element anchor behavior.
    - scroll-to-text-fragment-security.html has two expected failures, as
      they need to be updated to test cross-origin navigations. I'll make
      this change in a follow-up patch to close bug 1042311.

    Bug: 919204
  • Loading branch information
mkarolin committed Mar 19, 2020
commit 3221538c3b2939d11a3074be3d5c8f44b2540a6c
1 change: 1 addition & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
// Disabled features.
const std::unordered_set<const char*> disabled_features = {
autofill::features::kAutofillServerCommunication.name,
blink::features::kTextFragmentAnchor.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as well. Tested using https://example.com/#:~:text=domain

This needs to be added to: https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - once the PR is merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jumde added to Wiki.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkarolin

features::kAllowPopupsDuringPageUnload.name,
features::kAudioServiceOutOfProcess.name,
features::kLookalikeUrlNavigationSuggestionsUI.name,
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "content/public/common/web_preferences.h"
#include "gpu/config/gpu_finch_features.h"
#include "services/network/public/cpp/features.h"
#include "third_party/blink/public/common/features.h"

using BraveMainDelegateBrowserTest = InProcessBrowserTest;

Expand All @@ -42,6 +43,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisableHyperlinkAuditing) {
IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
const base::Feature* disabled_features[] = {
&autofill::features::kAutofillServerCommunication,
&blink::features::kTextFragmentAnchor,
&features::kAllowPopupsDuringPageUnload,
&features::kAudioServiceOutOfProcess,
&features::kNotificationTriggers,
Expand Down
1 change: 1 addition & 0 deletions test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,7 @@ test("brave_browser_tests") {
":brave_browser_tests_deps",
":browser_tests_runner",
"//testing/gmock",
"//third_party/blink/public/common",
]
# enable_plugins should be used here
if (!is_android) {
Expand Down