Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Chrome Google URL Tracker #248

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Disable Chrome Google URL Tracker #248

merged 1 commit into from
Jul 12, 2018
+44 −0

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 12, 2018 •
edited
Loading

Addresses brave/brave-browser#514

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
@bbondy bbondy self-assigned this Jul 12, 2018
@bbondy bbondy requested a review from simonhong July 12, 2018 06:21
simonhong
simonhong reviewed Jul 12, 2018
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
chromium_src/chrome/browser/google/chrome_google_url_tracker_client_browsertest.cc Outdated
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "brave/common/brave_switches.h"
#include "chrome/browser/google/chrome_google_url_tracker_client.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: order
@bbondy
Disable Chrome Google URL Tracker
d49d88e 
This disables connecting to client2.google.com, google.com and googleusercontent.com at startup.  The service is meant to select which google services you need for your region.

Addresses brave/brave-browser#514
@bbondy bbondy merged commit e808c50 into master Jul 12, 2018
@bbondy bbondy deleted the disable-url-tracker branch August 20, 2018 01:38
NejcZdovc added a commit that referenced this pull request Sep 18, 2019
@NejcZdovc
Merge pull request #248 from brave/hard-code
9cffee3 
Add hard coded translation
NejcZdovc added a commit that referenced this pull request Sep 19, 2019
@NejcZdovc
Imported from brave-ui: Merge pull request #248 from brave/hard-code
e3076d0 
Add hard coded translation
@MarkBuffalo MarkBuffalo mentioned this pull request Feb 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@bbondy @simonhong