Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable google services in privacy settings #244

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jul 11, 2018

Fix brave/brave-browser#512

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

npm run test -- brave_browser_tests --filter=BraveProfilePrefsBrowserTest.*

Open chrome://settings/privacy, below items should not be shown

  • Use a web service to help resolve navigation errors
  • Use a prediction service to help complete searches and URLs typed in the address bar
  • Automatically send some system information and page content to Google to help detect dangerous apps and sites
  • Use a web service to help resolve spelling errors

screen shot 2018-07-11 at 11 14 03 am

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
@yrliou yrliou self-assigned this Jul 11, 2018
@yrliou yrliou requested a review from bbondy July 11, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants