Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Chrome User Agent in M-SEARCH SSDP packets #22140

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Feb 18, 2024

Resolves brave/brave-browser#18017

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Same as brave/brave-browser#18017 (comment)

@ShivanKaul ShivanKaul requested a review from a team as a code owner February 18, 2024 08:30
@ShivanKaul ShivanKaul changed the title Use Google Chrome as ProductName for Dial Service Feb 18, 2024
@ShivanKaul ShivanKaul changed the title Send Google Chrome as User Agent instead of Brave in local M-SEARCH SSDP packets Feb 18, 2024
@goodov goodov requested a review from fmarier February 19, 2024 06:44
@ShivanKaul ShivanKaul changed the title Send "Google Chrome" as User Agent instead of "Brave <Channel>" in local M-SEARCH SSDP packets Feb 21, 2024
@ShivanKaul ShivanKaul merged commit 0428491 into master Feb 21, 2024
19 checks passed
@ShivanKaul ShivanKaul deleted the feature/change-ssdp-user-agent-chrome branch February 21, 2024 08:17
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 21, 2024
@bsclifton
Copy link
Member

Nice work @ShivanKaul 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants