Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crlsets with redirector #11917

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

linhkikuchi
Copy link
Collaborator

@linhkikuchi linhkikuchi commented Jan 20, 2022

Resolves brave/brave-browser#20609
For https://github.com/brave/devops/issues/3313

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Use Proxyman (MacOS) or mitmproxy, run the browser with fresh profile using the proxy ( e.g. --proxy-server="localhost:9090"), verify:

  • spellcheck dict request is 200 https://dict.brave.com/edgedl/chrome/dict/en-gb-9-0.bdic (the old request was https://crlsets.brave.com/edgedl/chrome/dict/en-gb-9-0.bdic)
  • all other /edgedl/release2/chrome_component/, /release2/chrome_component/, /dl/release2/chrome_component, /update-delta/hfnkpimlhhgieaddgfemjhofmfblmnib/, /edgedl/chromewebstore/, /edgedl/release2/, /update-delta/ggkkehgbnfjpeggfpleeakpidbkibbmn/ requests are now using https://redirector.brave.com and all return 200
  • other componentupdate requests should return 200 as well
  • go to brave://components and able to update CRLSet

Screen Shot 2022-01-21 at 11 22 17

@linhkikuchi linhkikuchi requested review from iefremov and a team as code owners January 20, 2022 06:37
@linhkikuchi linhkikuchi self-assigned this Jan 20, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Jan 20, 2022
@iefremov iefremov requested a review from fmarier January 20, 2022 09:32
@linhkikuchi linhkikuchi merged commit c215ec6 into master Jan 21, 2022
@linhkikuchi linhkikuchi deleted the linh-replace-crlsets-with-redirector branch January 21, 2022 06:02
@kjozwiak kjozwiak added this to the 1.36.x - Nightly milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
5 participants