Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR 126] Add Safety check section back to brave://settings/privacy #38850

Closed
1 of 6 tasks
rebron opened this issue Jun 5, 2024 · 6 comments · Fixed by brave/brave-core#24162
Closed
1 of 6 tasks

[CR 126] Add Safety check section back to brave://settings/privacy #38850

rebron opened this issue Jun 5, 2024 · 6 comments · Fixed by brave/brave-core#24162
Assignees
Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 5, 2024

Description

The Safety check section was removed from brave://settings/privacy in 1.66.x with this issue #36859

The Safety check section is needed for the unused permissions check.
https://issues.chromium.org/issues/40232296

Steps to reproduce

  1. Use 1.68.x with CR126
  2. Go to brave://settings/privacy
  3. Notice there is no Safety check section see: Expected Result section.

Actual result

In 1.66.x:
Screenshot 2024-06-05 at 4 49 18 PM

Expected result

Safety check section and functionality after Tor windows section.

Screenshot 2024-06-05 at 8 41 47 AM

and:

319751400-543a0a2b-9735-404d-b29d-da9ae1a042b2

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.x with CR 126

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Related issue: #38827 and #38825

cc: @fmarier @LaurenWags

@rebron rebron changed the title Add Safety check section back to brave://settings/privacy Jun 5, 2024
@rebron rebron added QA/Yes release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 6, 2024
@emerick
Copy link
Contributor

emerick commented Jun 6, 2024

Safety check will soon be replaced with Safety Hub upstream: https://issues.chromium.org/issues/40277421. Just wanted to make sure that we're still OK with this change, in light of that. cc: @fmarier

@fmarier
Copy link
Member

fmarier commented Jun 6, 2024

Is this just a rebrand, or is there something else in Safety Hub?

Maybe @ShivanKaul has seen this.

@emerick
Copy link
Contributor

emerick commented Jun 6, 2024

It seems to be (mostly?) a UI refresh, consisting of an interactive card-based interface:

Screenshot 2024-06-06 191149

@fmarier
Copy link
Member

fmarier commented Jun 7, 2024

Ok, we'll have to take the "Brave can check your passwords" card because we don't enable that service.

@kjozwiak
Copy link
Member

The above requires 1.67.115 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.115 Chromium: 126.0.6478.56 (Official Build) (64-bit)
-- | --
Revision | e1f8b4850805c2eea958bad7220c5e6e9202efaa
OS | Windows 10 Version 22H2 (Build 19045.4529)

Using the STR/Cases outlined via brave/brave-core#24162 (comment) & #38850 (comment), ensured that Safety Check was re-added into brave://settings/privacy. Also ensured that the correct icons were being used as per brave/brave-core#24162 (comment).

Example (before fix) Example (before fix)
image image
Example (after fix) Example (after fix) Example (after fix)
image image image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
6 participants