Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip Blackbaud email tracker #37971

Closed
fmarier opened this issue May 1, 2024 · 3 comments · Fixed by brave/brave-core#23358
Closed

Strip Blackbaud email tracker #37971

fmarier opened this issue May 1, 2024 · 3 comments · Fixed by brave/brave-core#23358

Comments

@fmarier
Copy link
Member

fmarier commented May 1, 2024

The bbeml parameter seems to be related to the Blackbaud fundraising and CRM platform.

Unfortunately, I couldn't find it in their documentation. It does however have enough entropy to uniquely identify users, and it was unnecessary in all of the URLs I looked at. For example, this one:

The unsubscribe link doesn't use this parameter and so it appears safe to remove.

I also appears on this list where it was added in this PR without any explanation.

@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels May 1, 2024
@fmarier fmarier added this to Untriaged Backlog in Security & Privacy via automation May 1, 2024
@fmarier fmarier self-assigned this May 1, 2024
fmarier added a commit to brave/brave-core that referenced this issue May 1, 2024
@fmarier fmarier moved this from Untriaged Backlog to Pending review in Security & Privacy May 1, 2024
Security & Privacy automation moved this from Pending review to Completed May 1, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 1, 2024
@stephendonner
Copy link

stephendonner commented May 7, 2024

Verification PASSED using

Brave | 1.67.73 Chromium: 125.0.6422.26 (Official Build) nightly (x86_64)
-- | --
Revision | 76e7d97680074902ad7bde84f0a1a6c392a4ca6a
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.67.73
  2. launched Brave
  3. ensured adblocking is set to Standard mode (not aggressive)
  4. opened https://brave.com/?bbeml=abcd&foo=bar
  5. examined the URL bar and confirmed that the bbeml parameter was removed. The foo=bar parameter should still be there
Screen Shot 2024-05-07 at 1 25 40 PM
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
-- | --
Revision | d01060f5ec155e6eb64a335203663a29c0e5d81f
OS | Windows 11 Version 23H2 (Build 22631.3593)
  1. installed 1.67.85
  2. launched Brave
  3. ensured adblocking is set to Standard mode (not aggressive)
  4. opened https://brave.com/?bbeml=abcd&foo=bar
  5. examined the URL bar and confirmed that the bbeml parameter was removed. The foo=bar parameter should still be there

image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2024
@hffvld
Copy link
Contributor

hffvld commented May 22, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.022 release-keys
Brave build: 1.67.85 
Chromium: 125.0.6422.60 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Strip Blackbaud email tracker brave-core#23358 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the bbeml parameter is removed.
  • Verified that the foo=bar parameter is not removed.

1 2 3
1 2 3
1 2 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment