Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Dark Mode Scrollbars on Windows #37882

Closed
jonathansampson opened this issue Apr 26, 2024 · 1 comment · Fixed by brave/brave-core#23301
Closed

Implement Dark Mode Scrollbars on Windows #37882

jonathansampson opened this issue Apr 26, 2024 · 1 comment · Fixed by brave/brave-core#23301
Labels
feature/new-tab feature-request OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.67.x - Release

Comments

@jonathansampson
Copy link
Contributor

Description

Regardless the theme of the OS, scrollbars on the New Tab Page always show in light-mode.

Actual result:

Scrollbars are always light.

Expected result:

Scrollbars should be styled consistently with other parts of Brave (e.g., Leo, Settings).

Reproduces how often:

Always.

Brave version (brave://version info)

1.65.122 Chromium: 124.0.6367.82 (Official Build) (64-bit)
jonathansampson added a commit to brave/brave-core that referenced this issue Apr 26, 2024
@jonathansampson
styles srollbars on new tab page
a05119c 
resolves brave/brave-browser#37882

This PR styles the scrollbar more consistently with scrollbars elsewhere in the browser (e.g., Leo in the sidebar). Default styling is applied for light mode, and explicit overrides are supplied for dark mode.
@jonathansampson jonathansampson mentioned this issue Apr 26, 2024
Merged
24 tasks
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include labels Apr 26, 2024
jonathansampson added a commit to brave/brave-core that referenced this issue May 3, 2024
@jonathansampson
styles srollbars on new tab page
a7e81a6 
resolves brave/brave-browser#37882

This PR styles the scrollbar more consistently with scrollbars elsewhere in the browser (e.g., Leo in the sidebar). Default styling is applied for light mode, and explicit overrides are supplied for dark mode.
jonathansampson added a commit to brave/brave-core that referenced this issue May 3, 2024
@jonathansampson
styles srollbars on new tab page (#23301)
7083318 
resolves brave/brave-browser#37882

This PR styles the scrollbar more consistently with scrollbars elsewhere in the browser (e.g., Leo in the sidebar). Default styling is applied for light mode, and explicit overrides are supplied for dark mode.
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 3, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.67.82 Chromium: 125.0.6422.41 (Official Build) beta (64-bit)
-- | --
Revision | cbebefd4c702801af65a196ba9701a907ed0d292
OS | Windows 10 Version 22H2 (Build 19045.4355)

Steps:

  1. installed 1.67.82
  2. launched Brave
  3. set Brave colors to Dark and Light modes,
  4. opened a new-tab page
  5. scrolled
  6. examined the scrollbars in Dark and Light modes
  7. compared to 1.66.104

Confirmed slimmer-styled and Dark and Light-mode appropriate scrollbars, matching brave/brave-core#23301 (comment)

Dark mode Light mode
image image

Scrollbars using 1.66.104 Chromium: 125.0.6422.41, for comparison:

Dark mode Light mode
image image
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab feature-request OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
5 participants
@stephendonner @jonathansampson @rebron @LaurenWags @brave-builds