Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced to keep Leo AI enabled, there is no way to disable it. #37394

Closed
InvisibleRasta opened this issue Apr 8, 2024 · 9 comments · Fixed by brave/brave-core#23021
Closed
Assignees
Labels
Projects

Comments

@InvisibleRasta
Copy link

InvisibleRasta commented Apr 8, 2024

I am using Brave 1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit)
What is the problem with leo.. I keep disabling it and it comes back on as soon as i open the sidebar...
I disabled it like 20 times alredy and as soon as I open the sidebar its activated again.
I also removed it from the sidebar countless times. As soon as I open the sidebar again it just reactivates itself.
Why are you hardcoding this crap and give us no option to permanently disable it as any other option.
how-to-disable-leo-v0-y2ku87afp9tc1

STR:

  1. Launch Brave
  2. Open leo side panel by clicking leo side panel icon
  3. Close by clicking leo side panel icon
  4. Remove leo panel icon via its context menu
  5. Click toolbar sidebar button

Actual result:
Leo panel is opened
Expected:
Other panel should be choosen as user removes leo panel icon

@rebron rebron added the feature/sidebar Relating to Brave's Sidebar feature label Apr 8, 2024
@rebron
Copy link
Collaborator

rebron commented Apr 8, 2024

cc: @simonhong This looks like a bug from the recent landing of setting Leo as default side panel. If a user hides Leo and doesn't choose anything else, because Leo is set as default side panel it will reappear.

@InvisibleRasta Thanks for filing the bug. If you choose bookmarks or reading list first, and then remove Leo side panel then it should work as expected for you as a workaround for now. We'll get this one fixed.

@rebron rebron added browser-ai priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Apr 8, 2024
@InvisibleRasta
Copy link
Author

how do i chose that? every time i open the sidebar no matter what leo opens up

@rebron
Copy link
Collaborator

rebron commented Apr 9, 2024

@InvisibleRasta Open the sidebar and select the bookmarks or reading list button.

@InvisibleRasta
Copy link
Author

It was just coming back, Not able to fix it. I ended up uninstalling the browser. I really liked the browsing experience but all the useless bloat we are forced to use makes no sense.
Why don't you make extensions instead of adding and forcing useless things to people.

@rebron
Copy link
Collaborator

rebron commented Apr 9, 2024

@InvisibleRasta If you just click on the bookmarks sidebar icon to open it, it'll remember that choice as your last selection.

@simonhong
Copy link
Member

simonhong commented Apr 9, 2024

@rebron we have a logic that adding back the opened panel's icon when its icon is hidden in sidebar.
It's intended to give that icon again to users when user opens that panel explicitely.
I think we should not choose hidden panel item when user clicks sidebar toolbar button.
Confirmed that toolbar doesn't launch hidden item.
But, deleted one is previsouly opened item, it's opened again and its icon is added back.
We should ignore previsouly opened item that removed already.

@simonhong simonhong self-assigned this Apr 9, 2024
@rebron rebron added this to Untriaged backlog in Front End Apr 10, 2024
@simonhong simonhong moved this from Untriaged backlog to In progress in Front End Apr 11, 2024
@simonhong
Copy link
Member

fixing now.

simonhong added a commit to brave/brave-core that referenced this issue Apr 11, 2024
fix brave/brave-browser#37394

SidePanelCoordinator::GetLastActiveEntryKey() gives previously
opened item even it's deleted item from sidebar UI.

When user want to open side panel w/o panel id, we only need to
use the value from sidebar::GetLastUsedSidePanel().
sidebar::GetLastUsedSidePanel() gives null if last opened panel
is removed already.
simonhong added a commit to brave/brave-core that referenced this issue Apr 11, 2024
fix brave/brave-browser#37394

SidePanelCoordinator::GetLastActiveEntryKey() gives previously
opened item even it's deleted item from sidebar UI.

When user want to open side panel w/o panel id, we only need to
use the value from sidebar::GetLastUsedSidePanel().
sidebar::GetLastUsedSidePanel() gives null if last opened panel
is removed already.
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 11, 2024
@rebron rebron moved this from In progress to Completed in Front End Apr 16, 2024
@stephendonner
Copy link

stephendonner commented May 2, 2024

Verification PASSED using

Brave | 1.67.56 Chromium: 124.0.6367.91 (Official Build) nightly (x86_64)
-- | --
Revision | 5670584eb8a1807ab8ac1584fb099bd21ec1e381
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.67.56
  2. launched Brave
  3. clicked to open the bookmarks side panel
  4. closed bookmarks side panel
  5. removed bookmarks side panel item
  6. clicked sidebar toolbar button

Confirmed that non-bookmarks side panel is opened

example example example example example
Screen Shot 2024-05-02 at 1 26 57 PM Screen Shot 2024-05-02 at 1 27 12 PM Screen Shot 2024-05-02 at 1 27 47 PM Screen Shot 2024-05-02 at 1 27 59 PM Screen Shot 2024-05-02 at 1 28 05 PM
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 2, 2024
@stephendonner
Copy link

stephendonner commented May 21, 2024

(Additional, original STR) Verification PASSED using

Brave | 1.67.90 Chromium: 125.0.6422.60 (Official Build) beta (x86_64)
-- | --
Revision | 64f9eec1a854079c3e529e908ca300071afb1f32
OS | macOS Version 14.5 (Build 23F79)

Steps:

  1. installed 1.67.90
  2. launched Brave
  3. open the Leo side panel by clicking its icon
  4. clicked to close it again, via its icon
  5. context-clicked and removed the Leo panel icon via its context menu
  6. clicked the browser toolbar's sidebar button

Confirmed it opened the reading list (sic) panel

Confirmed Show Leo icon in the sidebar pref was toggled to disabled/off, in brave://settings/leo-assistant

example example example example example example
Screenshot 2024-05-21 at 1 52 24 PM Screenshot 2024-05-21 at 1 52 34 PM Screenshot 2024-05-21 at 1 52 57 PM Screenshot 2024-05-21 at 1 53 07 PM Screenshot 2024-05-21 at 1 53 20 PM Screenshot 2024-05-21 at 1 53 58 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants