Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch Language launch iOS #36939

Closed
AndyAnds265 opened this issue Mar 19, 2024 · 3 comments · Fixed by brave/brave-core#22966
Closed

Dutch Language launch iOS #36939

AndyAnds265 opened this issue Mar 19, 2024 · 3 comments · Fixed by brave/brave-core#22966

Comments

@AndyAnds265
Copy link

Description:

We would like to add the Dutch language to our end of March Beta build and then rollout with the following release. To be specific, this entails adding the nl locale code. We are looking to use the general nl code not one attached to any country.

The localization is being worked on right now and it should be done within a week. I'm adding this ticket so that it can be slated in for the next iOS grooming discussion.

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@kjozwiak
Copy link
Member

The above requires 1.65.110 or higher for 1.65.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 17, 2024
@hffvld
Copy link
Contributor

hffvld commented Apr 18, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.65 (114)
BraveCore: 1.65.114 (124.0.6367.60)

Filed follow-up issue #37708 and #37709

STEPS:

  1. Set Dutchlanguage in device settings
  2. Launch Brave
  3. Verify

ACTUAL RESULTS:

  • Verified that Brave UI is translated to Dutch language

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
@hffvld
Copy link
Contributor

hffvld commented Apr 18, 2024

Verified on iPad Air using version(s):

Device/OS: iPad Air / iPadOS 16.7.2
Brave build: 1.65 (114)
BraveCore: 1.65.114 (124.0.6367.60)

STEPS:

  1. Set Dutchlanguage in device settings
  2. Launch Brave
  3. Verify

ACTUAL RESULTS:

  • Verified that Brave UI is translated to Dutch language

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment