Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engine for private window switching to standard SE in certain conditions #36758

Closed
samartnik opened this issue Mar 13, 2024 · 1 comment · Fixed by brave/brave-core#23288
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@samartnik
Copy link
Contributor

samartnik commented Mar 13, 2024

Description

Reported by customer https://community.brave.com/t/the-search-engine-for-private-window-keeps-switching-to-brave/536531

Additionally there is UI issue with bottom toolbar showing with wrong color in this case:

Screen_recording_20240425_105936.mp4

Steps to reproduce

  1. Set different search engines for private and standard tabs.
  2. Fully close the browser (e.g. via exit menu).
  3. Long tap on the icon and open private tab.
  4. Try to search anything, search engine set for standard tab will be used instead of private.

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Mar 13, 2024
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 20, 2024
@samartnik samartnik self-assigned this Apr 24, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 26, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 5, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 5, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.023.B4 release-keys
Brave build: 1.67.105
Chromium: 126.0.6478.26 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from Search engine for private window switching to standard SE in certain conditions #36758 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the search results are shown using a correct SE in a Private tab

2024-06-04_18-05-58.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
4 participants