Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Biometric Unlock toggle not updated in Wallet Settings #36669

Closed
StephenHeaps opened this issue Mar 10, 2024 · 1 comment · Fixed by brave/brave-core#22535
Closed

Allow Biometric Unlock toggle not updated in Wallet Settings #36669

StephenHeaps opened this issue Mar 10, 2024 · 1 comment · Fixed by brave/brave-core#22535
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include

Comments

@StephenHeaps
Copy link

StephenHeaps commented Mar 10, 2024

Description:

Allow Biometric Unlock toggle in Web3 settings is not updating correctly. Entering correct password will show the toggle as disabled until Web3 Settings is closed & re-opened. Sometimes entering an incorrect password then closing the modal (without entering correct password) can show the toggle as enabled until Web3 Settings is closed & re-opened.

Steps to Reproduce

  1. Setup wallet without biometrics, or disable in Web3 settings
  2. Enable Allow Biometric Unlock toggle in Web3 settings
  3. Enter password
  4. Observe toggle is still in disabled position
  5. Close Web3 Settings & re-open
  6. Toggle is in the enabled position

Actual result:

Allow Biometric Unlock toggle is enabled after entering correct password.
Allow Biometric Unlock toggle stays disabled if entering incorrect password & closing modal without entering correct password.

Allow.Biometrics.Unlock.bug.MP4

Expected result:

Entering the correct password should close the modal and show the Allow Biometric Unlock toggle as enabled.
Entering the incorrect password & dismissing modal without entering correct password should continue to show the Allow Biometric Unlock toggle as disabled.

Reproduces how often:

Easily reproduced issue with entering correct password and toggle is not showing as enabled.
Intermittent issue with entering incorrect password and toggle is showing as enabled.

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1710075181024309

@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Mar 10, 2024
@StephenHeaps StephenHeaps self-assigned this Mar 10, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 12, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 15, 2024
@hffvld
Copy link
Contributor

hffvld commented Apr 15, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.65 (112)
BraveCore: 1.65.112 (124.0.6367.29)

STEPS:

  1. Follow the steps from Allow Biometric Unlock toggle not updated in Wallet Settings #36669 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Allow Biometric Unlock toggle switch keeps staying OFF when Cancel is tapped or the wrong password is provided
  • Verified that the Allow Biometric Unlock toggle switch switched to ON when the correct password is provided

Reproduced with build 1.64.123

2024-04-15_13-15-40.mp4

Verified with build 1.65.112

2024-04-15_13-18-22.mp4
@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes release-notes/include
3 participants