Proposal for fixing custom bootstrap.less generator #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also work fine in Symfony < 2.5? |
|
@mumia Did you take a look at the failed test results? There seems to be a problem. |
|
@florianeckerstorfer no, I was in a hurry to finish the code I was working on. |
|
As far as I can see you just forgot to adapt the tests. |
mumia
force-pushed
the
issue300/generatorFailsForCustomVariable.less
branch
from
d7d3147
to
e7e4321
Compare
|
@florianeckerstorfer Updated the tests and added some protection for older versions of symfony. |
florianeckerstorfer
pushed a commit
that referenced
this pull request
Sep 18, 2014
…riable.less Proposal for fixing custom bootstrap.less generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers #300
This works well in SF 2.5.4.