Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to symfony 2.6 compatible form extensions #374

Closed
kralos opened this issue Jun 1, 2015 · 4 comments
Closed

Upgrade to symfony 2.6 compatible form extensions #374

kralos opened this issue Jun 1, 2015 · 4 comments

Comments

@kralos
Copy link
Contributor

kralos commented Jun 1, 2015

As of symfony 2.6

public function configureOptions(OptionsResolver $resolver)
{
    $resolver->setDefined(array(/** 'option1', 'option2' */));
}

should be used instead of:

public function setDefaultOptions(OptionsResolverInterface $resolver)
{
    $resolver->setOptional(array(/** 'option1', 'option2' */));
}

As of 2.7 the former method is also deprecated
@althaus
Copy link
Contributor

althaus commented Jun 2, 2015

👍
florianeckerstorfer pushed a commit that referenced this issue Jun 2, 2015
Merge pull request #375 from assimtech/symfony26
f166677 
#374 Upgrade to symfony 2.6 compatible form extensions
@kralos
Copy link
Contributor Author

kralos commented Jun 2, 2015

Fixed #375
@kralos kralos closed this as completed Jun 2, 2015
@althaus
Copy link
Contributor

althaus commented Jun 3, 2015

You missed to update the form types accordingly. I'll prepare a separate PR to fix this issue.
@althaus
Copy link
Contributor

althaus commented Jun 3, 2015

Sorry for the two commits here. Missed to tell the repo to not f*** up the lineendings at first. 🔨
@althaus althaus mentioned this issue Jun 3, 2015
Open
florianeckerstorfer pushed a commit that referenced this issue Jun 4, 2015
Merge pull request #376 from althaus/fix-formtypes
ea8792c 
Upgrade to Symfony 2.6 compatible form types (#374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@althaus @kralos