-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #274
Conversation
I had to update the .nvmrc to Node 18 to get an install to work
|
@@ -8,8 +8,8 @@ | |||
"private": true, | |||
"scripts": { | |||
"wp-env": "wp-env", | |||
"setup:tools": "yarn wp-env run composer install", | |||
"test": "yarn wp-env run phpunit phpunit -c /var/www/html/wp-content/plugins/wporg-two-factor/phpunit.xml.dist", | |||
"setup:tools": "yarn wp-env run cli --env-cwd=wp-content/plugins/wporg-two-factor composer install", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this and didn't run it, just composer install && yarn test
worked for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this depends on the version you have installed locally; I found running composer via the containers was more reliable.
The composer is also expecting to be able to modify ../../../mu-plugins/pub
which won't be in the right place when run outside of the containers.
I'm running v20 locally, but evidently whatever is default in github actions is working.. so.. I guess |
Yeah the workflows aren't calling |
I've bumped the nvm version, and pulled the package updates (since I didn't verify if it didn't change anything). I broke my local environment by restarting wp-env, so pushed it to see if the actions pass or fail.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't fully understand all the changes I've made in this PR, but it makes things pass.