Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy terms page #133

Closed
1 task
marko-srb opened this issue Jul 26, 2023 · 4 comments
Closed
1 task

Taxonomy terms page #133

marko-srb opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
[Component] Theme Templates, patterns, CSS
Milestone

Comments

@marko-srb
Copy link

marko-srb commented Jul 26, 2023

Figma Source

We have several ways of wayfinding:

  1. Categories (we should have only five — ones present in mockups)
  2. Flavors (we should have only five — ones present in mockups)
  3. Tags

Note. There's back to top button on mobile, which should follow the bottom of the screen, while scrolling.

  • Some copy checking/additions should happen by Stargate.
Mobile Desktop Monitor
(Mobile) Showcase - Tags (Desktop) Showcase - Tags-1 (Monitor) Showcase - Tags
@StevenDufresne StevenDufresne added this to the MVP milestone Jul 28, 2023
@ryelle ryelle changed the title Showcase Tags / Wayfinding Aug 1, 2023
@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Aug 1, 2023
@ryelle ryelle self-assigned this Sep 19, 2023
ryelle added a commit that referenced this issue Sep 20, 2023
ryelle added a commit that referenced this issue Sep 20, 2023
ryelle added a commit that referenced this issue Sep 20, 2023
@ryelle
Copy link
Contributor

ryelle commented Sep 20, 2023

I've got a first pass of this up at https://wordpress.org/showcase-v2/browse/

This uses two new blocks, "Term Grid" and "Tags Archive". If the "Term Grid" pattern is used again (IIRC it is used in the Learn/Docs/etc mockups), we can move that to wporg-mu-plugins, but for faster development I added it here.

There are currently fewer tags on the site than there are in the mockup, so I was a little worried the alphabetical separation would be sparse, but it's not too bad.

@WordPress/meta-design No PR to review, I deployed the code to the staging site already— feel free to leave any feedback for this page on this issue, otherwise if it looks good we can close this 🙂

@jasmussen
Copy link

Nice, at a glance this looks quite good, well done.

The one thing that comes to mind is actually for the tag results page, which looks like this:

Screenshot 2023-09-20 at 09 08 28

Note here the spacing below the site and above the dots, it's a bit on the short side. I realize this is fully as expected with the mockups, where it's only when pagination is available that it's pushed down the extra 80px, like so:

Screenshot 2023-09-20 at 09 08 10

But can we do it so that regardless of pagination or not, there's always 80px of space between dots and the last site? I.e.

Screenshot 2023-09-20 at 09 08 21

The way I did it in Figma was to set a fixed height on the pagination box, and just hide the pagination. So visually they could be identical, pagination or not. Let me know if that could work. It's not a blocker or urgent, but would be a nice enhancement.

@ryelle
Copy link
Contributor

ryelle commented Sep 20, 2023

@jasmussen That's an issue with the archive template, not this page, could you create a new issue for that?

@ryelle
Copy link
Contributor

ryelle commented Sep 20, 2023

Since there's no feedback on the page itself, I'll consider this page done 👍🏻

@ryelle ryelle closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
4 participants