Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local nav bar visual elements #195

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

allancole
Copy link
Collaborator

This PR changes the square separator to a circular shape and adjusts the default color state for the News link.

Before:
image

After:
image

Figma reference:
image

Note: I replaced the pseudo element square shape with a unicode "bullet" method which requires a few less lines of code. I tried to simply add a border radius, but once that shape got below 3px, the border-radius had no effect.

Fixes: #194

@allancole allancole added the [Component] Theme Front-end help needed label Jan 13, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 13, 2022

@shaunandrews This was changed from a bullet to a square in #178 yesterday, can you take a look here?

@shaunandrews
Copy link
Collaborator

I reused the CSS I wrote for the current category; I didn't notice it was supposed to be a circle.

I tried to simply add a border radius, but once that shape got below 3px, the border-radius had no effect.

I don't have a strong preference, but this same method is used in a few other places — using the bullet character feels a little less accurate than actually defining the size in pixels of the pseudo-element.

I just tried it and a border-radius works fine for me — I pushed the changes to make sure.

@ryelle ryelle self-requested a review January 14, 2022 16:00
@shaunandrews shaunandrews merged commit 798ccd1 into trunk Jan 14, 2022
@shaunandrews shaunandrews deleted the fix/local-nav-bar-visual-elements branch January 14, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Front-end help needed
3 participants