Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Add a pattern that can be used for "pages in progress" #463

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Jul 4, 2024

Some pages shouldn't be fully public (& indexed by search engines) until they're "finished", but we need them published to sync the content to version control + glotpress. Once the page template and pattern are created though, we can swap out the pattern to a placeholder version. This should keep the editor preview working correctly, while not showing the content to regular viewers.

This approach adds a new pattern wporg-main-2022/work-in-progress, which can be swapped out on the page template (I resisted the urge to find an under construction gif 😂).

In this case, the content on the pattern references the 6.6 release page, just in case users land on this page from a search engine. Once the 6.6 page is public, we can change out this text with something more generic (cc @thetinyl). Most people will not see this content though.

The content here is not translated, since these strings are only temporary. If we decide to add a more generic message for the future, we can i18n-ize those.

Screenshots

@WordPress/meta-design — again most people won't see this, but let me know if you want to change anything.

How to test the changes in this Pull Request:

  1. View the /download/releases/6-6 page
  2. You should not see the real page content
  3. You should see a "coming soon" message
@ryelle ryelle added the [Component] Content Bugs or issues related to the page content label Jul 4, 2024
@ryelle ryelle self-assigned this Jul 4, 2024
@jasmussen
Copy link
Contributor

Looks good, let's get this out there. If we wanted to really polish it, I'd probably go all-white, with a white footer, and a gray border between header/footer/content. But what's here can work just fine, color-wise, especially if that's easier for you. Text-wise, I'd be tempted to simplify this a bit too. Two quick options, not blockers:

Coming Soon alt

Coming Soon

@thetinyl
Copy link
Collaborator

thetinyl commented Jul 5, 2024

I think this page should always be generic (if it needs to exist)—even before the release ships. It's one less thing to remember to update and even if its purpose is to never be found, we might as well make it just a little more useful to the small number of visitors it might get.

My suggestion for copy:

You’re looking for what’s new in WordPress

Go right to the source:

If we wanted to be a little cheeky, we could replace "Go right to the source:" with:

You’re looking for what’s new in WordPress

Lurk where the updates are:

[insert same links]

We can use other links. I'm suggesting the proposed because News and Dev Blog will include insights into ongoing releases. Events is just another opportunity to drive people to engage with the community (without necessarily asking for contribution).

@ryelle
Copy link
Contributor Author

ryelle commented Jul 6, 2024

If we wanted to really polish it, I'd probably go all-white, with a white footer, and a gray border between header/footer/content.

We can't change the header/footer— or if we do, it will impact the preview of the in-progress page, since the template wrapper needs to stay the same. So this in-progress page may appear with different header-footer combos, for example if we used it on 6.3, it would have a black header & footer.

I've gone ahead with the first copy option, @thetinyl, just to get something deployed soon, but since it didn't sound final I've omitted translation tags. Once you know what the copy should be, I can update it properly.

@ryelle ryelle merged commit 2200606 into trunk Jul 6, 2024
2 checks passed
@ryelle ryelle deleted the try/wip-pattern branch July 6, 2024 16:53
@thetinyl
Copy link
Collaborator

thetinyl commented Jul 8, 2024

Once you know what the copy should be, I can update it properly.

My only suggested tweak would be to move the WP News link to the top of the list. Otherwise, I think what's there is good for now.

Thanks @ryelle!

@ryelle
Copy link
Contributor Author

ryelle commented Jul 8, 2024

huh, I have no idea how they got reorganized, I copied the list from your comment. I'll make that update & get them translatable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Bugs or issues related to the page content
3 participants