-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content updates from Page Editor #460
Conversation
37c1f83
to
76b074e
Compare
<!-- wp:paragraph --> | ||
<p></p> | ||
<!-- /wp:paragraph --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasmussen Is this empty paragraph here on purpose? It's after the preview section:
![Screenshot 2024-07-02 at 10 34 56 AM](https://cdn.statically.io/img/private-user-images.githubusercontent.com/541093/345075458-e626b84c-c533-4128-a197-a790477207db.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5MjkyNTksIm5iZiI6MTcyMjkyODk1OSwicGF0aCI6Ii81NDEwOTMvMzQ1MDc1NDU4LWU2MjZiODRjLWM1MzMtNDEyOC1hMTk3LWE3OTA0NzcyMDdkYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgwNlQwNzIyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05OGU1NGEyNWMzOGUzZTYzNGU5NTVlZmI3NjI0N2ZkN2E2NDkwMmQwNzE5Y2VjZjBkNTE3N2FkYjEyYTY5NjBjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.tJ0KYPnNA2DUQGqW9mY2eC2rkmFM90wvHGzYkew39lM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that was not on purpose, sorry.
<!-- /wp:image --></div> | ||
<!-- /wp:column --></div> | ||
<!-- /wp:columns --></div> | ||
<!-- /wp:group --> | ||
|
||
<!-- wp:block {"ref":41176} /--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasmussen After looking at the page I see this is just a separator, but can you swap it out for the original anyway? Just to make it clear what's on the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, so it's a preference to not use synced patterns? I'll detach all of them, and note this for later.
I'll make some updates now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, so it's a preference to not use synced patterns?
Yes, since they're not part of the content sync process, they're not tracked in version control & don't get the translation wrappers (and there's no way, looking at this, to tell it doesn't have content).
If synced patterns are important for your workflow, we could probably make that work somehow (with either a similar sync process as the content or some kind of replacement flow), but that would be a separate task. Let me know if you need that, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synced patterns are useful and will be more useful in the future as we get content and style overrides. But it's not a deal-breaker to have to detach them, there's just a chance that things meant to be reusable start to drift. Fine with me for now, and the foreseeable future, so not something to prioritize especially, and thanks for explaining.
Okay, detached all synced patterns, and removed the stray paragraph. All OK now? |
76b074e
to
aad37a9
Compare
The content has changed in the Page Editor.
Please review, merge, and deploy.