Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates from Page Editor #460

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Content updates from Page Editor #460

merged 2 commits into from
Jul 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2024

The content has changed in the Page Editor.
Please review, merge, and deploy.

@github-actions github-actions bot force-pushed the automated/content-update branch 2 times, most recently from 37c1f83 to 76b074e Compare July 2, 2024 08:46
Comment on lines 96 to 98
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen Is this empty paragraph here on purpose? It's after the preview section:

Screenshot 2024-07-02 at 10 34 56 AM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was not on purpose, sorry.

<!-- /wp:image --></div>
<!-- /wp:column --></div>
<!-- /wp:columns --></div>
<!-- /wp:group -->

<!-- wp:block {"ref":41176} /-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen After looking at the page I see this is just a separator, but can you swap it out for the original anyway? Just to make it clear what's on the page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, so it's a preference to not use synced patterns? I'll detach all of them, and note this for later.

I'll make some updates now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, so it's a preference to not use synced patterns?

Yes, since they're not part of the content sync process, they're not tracked in version control & don't get the translation wrappers (and there's no way, looking at this, to tell it doesn't have content).

If synced patterns are important for your workflow, we could probably make that work somehow (with either a similar sync process as the content or some kind of replacement flow), but that would be a separate task. Let me know if you need that, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced patterns are useful and will be more useful in the future as we get content and style overrides. But it's not a deal-breaker to have to detach them, there's just a chance that things meant to be reusable start to drift. Fine with me for now, and the foreseeable future, so not something to prioritize especially, and thanks for explaining.

@jasmussen
Copy link
Contributor

Okay, detached all synced patterns, and removed the stray paragraph. All OK now?

@ryelle ryelle merged commit baeab7f into trunk Jul 2, 2024
2 checks passed
@ryelle ryelle deleted the automated/content-update branch July 2, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants