Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Directory: Increase paragraph line height #413

Closed
beafialho opened this issue Apr 4, 2024 · 3 comments
Closed

Plugin Directory: Increase paragraph line height #413

beafialho opened this issue Apr 4, 2024 · 3 comments

Comments

@beafialho
Copy link

Currently, the line height of the Plugin Directory seems a bit too tight. I suggest increasing it and matching with the rest of the site for a more comfortable reading and browsing experience.

plugins-page.mp4

cc: @jasmussen
@ryelle
Copy link
Contributor

ryelle commented Apr 4, 2024

This caught my eye because the parent theme should provide the right styles, but it looks like the plugin theme is still loading all the legacy styles.

It would probably be enough to remove client/styles/base/_copy.scss, but I tried a 🔥 🔥 approach getting rid of all of these that should be handled by the parent theme styles now.

D       client/styles/base
D       client/styles/base/_base.scss
D       client/styles/base/_copy.scss
D       client/styles/base/_tables.scss
D       client/styles/components/_captions.scss
D       client/styles/components/_components.scss
D       client/styles/components/_galleries.scss
D       client/styles/components/_media.scss
D       client/styles/generic
D       client/styles/generic/_generic.scss
D       client/styles/navigation
D       client/styles/navigation/_menus.scss
D       client/styles/navigation/_navigation.scss
D       client/styles/objects/_fields.scss
D       client/styles/objects/_objects.scss
D       client/styles/objects/_page_releases.scss
D       client/styles/settings/_colors.scss
D       client/styles/settings/_settings.scss
D       client/styles/settings/_typography.scss
D       client/styles/trumps
D       client/styles/trumps/_trumps.scss

The full patch is here: https://gist.github.com/ryelle/b98a41afc597ba64100e8fa9b728d398

@StevenDufresne @dd32 This is a pretty big change for not being involved much yet, so what do you think?

Home Single plugin
Screen Shot 2024-04-04 at 17 57 05-fullpage Screen Shot 2024-04-04 at 17 57 28-fullpage
@StevenDufresne
Copy link
Contributor

There aren't many hidden surprises with the plugin directory. I'm fine with this cleanup. Apply it. I'll run some tests on Monday before we send this back out for QA.
bazza pushed a commit to WordPress/wordpress.org that referenced this issue Apr 5, 2024
@ryelle
wporg-plugins-2024: Remove legacy CSS.
df3d947 
This removes the CSS that was copied over from the previous classic theme. The parent block theme should provide the correct base styles.

See WordPress/wporg-main-2022#413



git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13466 74240141-8908-4e6f-9713-ba540dce6ec7
@ryelle
Copy link
Contributor

ryelle commented Apr 5, 2024

Okay, I've done that in this commit. That fixes the line-height, as it's now correctly inheriting the style from the parent theme.
@ryelle ryelle closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@ryelle @StevenDufresne @beafialho