Add the new site-header template for the DotOrg design #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
reviewed
Jun 4, 2024
Add some changes in the generation of the social tags
psrpinto
reviewed
Jun 5, 2024
| echo do_blocks( '<!-- wp:wporg/global-header /-->' ); | ||
|
|
||
| gp_enqueue_styles( array( 'gp-jquery-webui-popover', 'driver-js' ) ); | ||
| gp_enqueue_scripts( array( 'gp-tour' ) ); |
There was a problem hiding this comment.
Would it make sense to use wp_enqueue_styles() and wp_enqueue_scripts() instead? Also, I'm wondering if we need the tour in the Translation Events (I'm assuming jquery-webui-popover and driver-js are for the tour).
psrpinto
reviewed
Jun 6, 2024
|
|
||
| ?> | ||
|
|
||
| <div class="event-list-top-bar"> |
There was a problem hiding this comment.
I think it could make sense to remove this from this PR for now, as it doesn't currently adhere to the new design, and implement it in a later PR with the new design.
psrpinto
approved these changes
Jun 7, 2024
|
Merging, we can iterate in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new design for the site-header at translate.wordpress.org, using only blocks. This PR:
site-headertemplate in the new design.global-headerblock.gp_tmpl_header();method.Currently, this PR only works in My events, because we don't have another main templates in the new design.
New design with the current template system
New design with blocks
Currently, we have a problem with the breadcrumb at translate.wordpress.org, because it is not working. We should address this problem in a future PR.