Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update css.md - correct grammar error #139

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Update css.md - correct grammar error #139

merged 2 commits into from
Jul 7, 2024

Conversation

adeleke-akinade
Copy link
Contributor

@adeleke-akinade adeleke-akinade commented Jul 5, 2024 •
edited
Loading

Corrects grammar error.
@adeleke-akinade
Update css.md
12b0e5f 
Corrects typos.
@adeleke-akinade adeleke-akinade changed the title Update css.md Jul 5, 2024
jrfnl
jrfnl reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. In my opinion, only the change on line 160 has merit. The other changes are not fixing typos nor grammatical errors.
@adeleke-akinade
Copy link
Contributor Author

You're welcome.

Regarding the first change: "from core code to themes to plugins" to "from core code to themes and plugins". I think the latter reads nicer. However, that may be down to opinion.

Regarding the second change: "Just as CSS is evolving, so our standards will evolve with it" sounds incorrect to me. What is the purpose of the word "so" here?
@jrfnl
Copy link
Member

jrfnl commented Jul 6, 2024

Regarding the second change: "Just as CSS is evolving, so our standards will evolve with it" sounds incorrect to me. What is the purpose of the word "so" here?

That's a typical grammatical construct in English.
Here are some references about it:
@adeleke-akinade
Update css.md
28ab066 
Reverts two prior changes.
@adeleke-akinade adeleke-akinade changed the title Update css.md - corrects typos Jul 6, 2024
@adeleke-akinade
Copy link
Contributor Author

Fair enough. From the links you shared, I can see it is perfectly valid.

I have updated the PR so it includes only the single change on line 160.
jrfnl
jrfnl approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working with me to get this merge ready @adeleke-akinade !
@adeleke-akinade
Copy link
Contributor Author

You're very welcome @jrfnl
@adeleke-akinade
Copy link
Contributor Author

@jrfnl is it ready to merge now?
@adeleke-akinade adeleke-akinade changed the title Update css.md - corrects a grammar error Jul 6, 2024
@dingo-d dingo-d merged commit 366c87a into WordPress:master Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@adeleke-akinade @jrfnl @dingo-d