Plugin Directory: Release Confirmation: Require 2FA instead of email verification #344
+139
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he plugin page, rather than on the releases page (for now)
bazza
pushed a commit
that referenced
this pull request
Jul 26, 2024
…clearer it's purpose. See #344. See #7704. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13929 74240141-8908-4e6f-9713-ba540dce6ec7
bazza
pushed a commit
that referenced
this pull request
Jul 26, 2024
… page-headers to the shortcode. See #344. See #7704. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13930 74240141-8908-4e6f-9713-ba540dce6ec7
bazza
pushed a commit
that referenced
this pull request
Jul 26, 2024
…ic from the theme to the Shortcode. See #344. See #7704. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13931 74240141-8908-4e6f-9713-ba540dce6ec7
dd32
force-pushed
the
plugins/add/release-2fa
branch
from
69b7549
to
984b49c
Compare
|
Rather than having a prompt to 2FA, this would be better implemented if the buttons were just shown as clickable, but upon click the JS handler for revalidation prompted it at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has 2FA setup, we should rely upon that instead of email.
This is more secure, and for those who are using Keys, likely more streamlined.
This is a work in progress, and requires a few more steps.
See https://meta.trac.wordpress.org/ticket/7704
This is reliant upon WordPress/wporg-two-factor#283