Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Plugin single links and buttons missing hover states #263

Closed
amberhinds opened this issue Apr 16, 2024 · 5 comments
Closed
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins

Comments

@amberhinds
Copy link

On the plugin single page (Gutenberg plugin test page), the buttons and links are all missing hover states.

On hover, text links should have the underline removed.

On hover, buttons need a design change that either contrasts with the default state or is other wise visually distinct (switching from solid to underline or adding an icon, for example).

@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

the buttons and links are all missing hover states.

It looks like these are not using the correct button styles — but if the old button classes are replaced with the block classes wp-block-button__link in the markup, that should help.

On hover, text links should have the underline removed.

Yeah, this is a bug.

On hover, buttons need a design change that either contrasts with the default state or is other wise visually distinct (switching from solid to underline or adding an icon, for example).

We recently had a discussion about button styles, and from my research and understanding of the guidelines, the fact that the mouse cursor changes from default to pointer is enough of a change — although by default, the blue buttons should get slightly darker on hover. https://wordpress.org/download/ shows these buttons the way they're supposed to work.

@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins labels Apr 16, 2024
@StevenDufresne
Copy link
Contributor

StevenDufresne commented Apr 22, 2024

@WordPress/meta-design Do these need to be buttons? Can they not just be links? I don't know if we have an agreed-upon scenario where a button is preferred.

Before After
Screenshot 2024-04-22 at 10 22 52 AM Screenshot 2024-04-22 at 10 22 48 AM

Edit

The ratings section above doesn't include a button.

Screenshot 2024-04-22 at 10 25 59 AM
@jasmussen
Copy link

Links look good 👍 👍

@ndiego
Copy link
Member

ndiego commented Apr 22, 2024

Links look good 👍 👍

Agreed, links look good and removing the buttons also increases the prominence of the Download and Live Preview (for those plugins that have it) buttons.

bazza pushed a commit that referenced this issue Apr 23, 2024
bazza pushed a commit that referenced this issue Apr 23, 2024
bazza pushed a commit that referenced this issue Apr 30, 2024
See: #263
Props: alh0319


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13617 74240141-8908-4e6f-9713-ba540dce6ec7
bazza pushed a commit that referenced this issue May 9, 2024
…omponents that need further thought.

See: #263
Props: alh0319, ryelle 
-This line, and those below, will be ignored--

M    wporg-plugins-2024/client/components/plugin/_favorite-button.scss
M    wporg-plugins-2024/client/components/plugin/style.scss
M    wporg-plugins-2024/client/components/widget-area/_widgets-meta.scss
D    wporg-plugins-2024/client/styles/objects/_links.scss
M    wporg-plugins-2024/client/styles/objects/_objects.scss
M    wporg-plugins-2024/css/style-rtl.css
M    wporg-plugins-2024/css/style.css


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13680 74240141-8908-4e6f-9713-ba540dce6ec7
@StevenDufresne
Copy link
Contributor

I made underlined as the default for the theme and updated button states. If any components are missing links or inconsistent, let's open up new tickets for those specific changes.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Site] Plugins
5 participants