Build: Ship the default TypeScript .d.ts declaration files, not rollups #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeline. This caused the published packages to ship not just their own types but also all the types they import. This creates a lot of noise and also type identity conflicts between packages. This PR removes most of these rollup tasks, leaving only two: * In the `@wp-playground/blueprints` package for Types->JSON schema generation * In the `@wp-playground/client` package to make it self-contained and dependencyless. ## Testing instructions Run `npm run build` and confirm the built packages only export their own types.
adamziel
added
[Type] Bug
brandonpayton
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipeline. This caused the published packages to ship not just their own types but also all the types they import. This creates a lot of noise and also type identity conflicts between packages. This PR removes most of these rollup tasks, leaving only two:
@wp-playground/blueprintspackage for Types->JSON schema generation@wp-playground/clientpackage to make it self-contained and dependencyless.Related to #1577
Testing instructions
Run
npm run buildand confirm the built packages only export their own types.