Vite build: Mark all imported modules as external to avoid bundling them with released packages. #1586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, many of the released packages bundle other packages – both from this repo and external ones.
For example,
@wp-playground/wordpress
bundles@php-wasm/node
which caused multiple copies of that package to be loaded and create a variable identity issues such as #1579.This PR marks all the dependent packages as external and ensures the published packages are lean and only contains their own code.
Testing instructions
Run
nx build php-wasm-node
and confirm the resultingdist/packages/playground/client/index.js
file and other built npm-published modules do not bundle any external modules. The only exception should be thecli
packages.