Update the Blueprint data format doc #1510
Merged
+72
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
requested changes
Jun 17, 2024
|
|
||
| - `light`: Default choice. Saves 6MB of downloads, loads none of the extensions below. | ||
| - `kitchen-sink`: Installs [`gd`](https://www.php.net/manual/en/book.image.php), [`mbstring`](https://www.php.net/manual/en/mbstring.installation.php), [`iconv`](https://www.php.net/manual/en/function.iconv.php), [`openssl`](https://www.php.net/manual/en/book.openssl.php), [`libxml`](https://www.php.net/manual/en/book.libxml.php), [`xml`](https://www.php.net/manual/en/xml.installation.php), [`dom`](https://www.php.net/manual/en/intro.dom.php), [`simplexml`](https://www.php.net/manual/en/book.simplexml.php), [`xmlreader`](https://www.php.net/manual/en/book.xmlreader.php), [`xmlwriter`](https://www.php.net/manual/en/book.xmlwriter.php) | ||
| - `light`: Default choice. It saves 6MB of downloads and loads none of the extensions below. |
|
Thank you for the updates. I left a couple of notes, but the changes look good to me overall. |
Co-authored-by: Brandon Payton <brandon@happycode.net>
|
@brandonpayton feel free to merge (and make a call on merging PRs in general). |
|
Ah, I see, there's still pending feedback. Pingy ping @ndiego |
Oops, sorry about that. I just made the update requested. Should be all good! |
|
Thank you so much @ndiego ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some light updates to the Blueprint data Format documentation. The doc is now more streamlined, and code examples are provided for each property. I also added a dedicated section for Steps.
Titles are also now in sentence case to match the WP style guide.