Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline comment next to Emscripten version as reminder to upgrade PHP libraries #1501

Merged

Conversation

fluiddot
Copy link
Contributor

Motivation for the change, related issues

This PR is related to this comment regarding adding a note when upgrading the Emscripten version.

Implementation details

  • Add inline comment to base-image Dockerfile.

Testing Instructions (or ideally a Blueprint)

N/A

@adamziel
Copy link
Collaborator

I expanded the comment but it LGTM otherwise, thank you @fluiddot!

@adamziel adamziel merged commit 9fd8cdb into WordPress:trunk Jun 11, 2024
1 check passed
@fluiddot fluiddot deleted the add/note-upgrade-emscripten-version branch June 11, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants